Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fcm): Add missing WebpushFcmOptions entity (as per documentation) #295

Merged
merged 4 commits into from Aug 6, 2019
Merged

feat(fcm): Add missing WebpushFcmOptions entity (as per documentation) #295

merged 4 commits into from Aug 6, 2019

Conversation

@kirmerzlikin
Copy link
Contributor

@kirmerzlikin kirmerzlikin commented Aug 1, 2019

WebpushFcmOptions is described in documentation but is not included in Java client.

Corresponding issue - #294

RELEASE NOTE: Added a new WebpushFcmOptions API for configuring the features provided by the FCM SDK for Web.

@googlebot
Copy link

@googlebot googlebot commented Aug 1, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Loading

@kirmerzlikin
Copy link
Contributor Author

@kirmerzlikin kirmerzlikin commented Aug 1, 2019

@googlebot I signed it!

Loading

@googlebot
Copy link

@googlebot googlebot commented Aug 1, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Loading

Copy link
Member

@hiranya911 hiranya911 left a comment

Thanks for working on this @kirmerzlikin. Can you make sure the new class has the following public API:

class WebpushFcmOptions
     static Builder builder()
     static WebpushFcmOptions withLink(String link)
     class Builder
         Builder setLink(String link)
         WebpushFcmOptions build()

Loading

Loading
@googlebot
Copy link

@googlebot googlebot commented Aug 2, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Loading

@googlebot
Copy link

@googlebot googlebot commented Aug 2, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Loading

@kirmerzlikin
Copy link
Contributor Author

@kirmerzlikin kirmerzlikin commented Aug 2, 2019

Loading

@kirmerzlikin kirmerzlikin marked this pull request as ready for review Aug 2, 2019
Copy link
Member

@hiranya911 hiranya911 left a comment

Approved with a couple of suggestions. Please make those changes, and then I can merge. Also please add an entry to CHANGELOG file.

Loading

Loading
Loading
@hiranya911
Copy link
Member

@hiranya911 hiranya911 commented Aug 2, 2019

@egilmorez can you review the javadoc-related changes in this PR?

Loading

CHANGELOG.md Outdated Show resolved Hide resolved
Loading
Copy link
Contributor

@egilmorez egilmorez left a comment

Looks great, thanks!

Just one nit on one sentence.

Loading

@hiranya911 hiranya911 assigned kirmerzlikin and unassigned egilmorez Aug 5, 2019
@hiranya911
Copy link
Member

@hiranya911 hiranya911 commented Aug 5, 2019

Thanks @kirmerzlikin. I can merge once you make the change suggested by Eric.

Loading

@kirmerzlikin
Copy link
Contributor Author

@kirmerzlikin kirmerzlikin commented Aug 6, 2019

Loading

@hiranya911 hiranya911 merged commit 0a06159 into firebase:master Aug 6, 2019
3 checks passed
Loading
@hiranya911 hiranya911 changed the title Add missing WebpushFcmOptions entity (as per documentation) feat(fcm): Add missing WebpushFcmOptions entity (as per documentation) Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants