chore: Enabling max-len lint rule #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiranya911
force-pushed
the
hkj-max-len
branch
from
9f9ca06
to
f2ad573
Compare
lahirumaramba
approved these changes
Aug 31, 2020
| @@ -246,7 +246,7 @@ describe('admin.remoteConfig', () => { | |||
| INVALID_JSON_STRINGS.forEach((invalidJson) => { | |||
| it(`should throw if the json string is ${JSON.stringify(invalidJson)}`, () => { | |||
| expect(() => admin.remoteConfig().createTemplateFromJSON(invalidJson)) | |||
| .to.throw(/^Failed to parse the JSON string: ([\D\w]*)\. SyntaxError: Unexpected token ([\D\w]*) in JSON at position ([0-9]*)$/); | |||
| .to.throw(/Failed to parse the JSON string/); | |||
There was a problem hiding this comment.
Did this pass integration test? I thought the regex should match the complete message.
There was a problem hiding this comment.
That was because the regex was defined with ^...$ symbols. Without them you don't need to match the whole message.
| }); | ||
| }); | ||
|
|
||
| ['abc', 'a123b', 'a123', '123a', 1.2, '70.2'].forEach( |
| }); | ||
| }); | ||
|
|
||
| ['abc', 'a123b', 'a123', '123a', 1.2, '70.2'].forEach((invalidVersion) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm enabling the
max-lenlint rule with a max line length of 120. Ideally we should be using a max line length of 100, but we have way too many violations to attempt that right now.