Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): Support sms region config change on Tenant and Project level. #1673

Merged
merged 10 commits into from Apr 28, 2022
Merged

feat(auth): Support sms region config change on Tenant and Project level. #1673

merged 10 commits into from Apr 28, 2022

Conversation

Xiaoshouzi-gh
Copy link
Contributor

Support sms region config change on Tenant and Project level.
Added unit and integration tests.
Note the following changes were reviewed in recaptcha branch:

  • src/auth/auth-api-request.ts
  • src/auth/auth.ts
  • src/auth/project-config-manager.ts
  • Most of test/unit/auth/project-config-manager.spec.ts

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

renkelvin
renkelvin approved these changes Apr 27, 2022
View reviewed changes
src/auth/project-config.ts Outdated Show resolved Hide resolved
@lahirumaramba lahirumaramba changed the title Support sms region config change on Tenant and Project level. feat(auth): Support sms region config change on Tenant and Project level. Apr 27, 2022
lahirumaramba
lahirumaramba approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!
Left a few cleanup comments.

src/auth/auth-config.ts Outdated Show resolved Hide resolved
src/auth/auth-config.ts Show resolved Hide resolved
src/auth/auth.ts Outdated Show resolved Hide resolved
src/auth/project-config-manager.ts Outdated Show resolved Hide resolved
prameshj
prameshj reviewed Apr 27, 2022
View reviewed changes
Copy link

@prameshj prameshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits, otherwise looks good to me.

src/auth/auth-config.ts Show resolved Hide resolved
src/auth/auth-config.ts Show resolved Hide resolved
src/auth/auth-config.ts Outdated Show resolved Hide resolved
src/auth/auth-config.ts Outdated Show resolved Hide resolved
src/auth/auth-config.ts Show resolved Hide resolved
src/auth/auth-config.ts Outdated Show resolved Hide resolved
src/auth/project-config.ts Outdated Show resolved Hide resolved
src/auth/project-config.ts Show resolved Hide resolved
kevinthecheung
kevinthecheung approved these changes Apr 28, 2022
View reviewed changes
src/auth/tenant.ts Show resolved Hide resolved
src/auth/project-config.ts Outdated Show resolved Hide resolved
src/auth/project-config.ts Outdated Show resolved Hide resolved
src/auth/project-config.ts Outdated Show resolved Hide resolved
src/auth/project-config-manager.ts Outdated Show resolved Hide resolved
src/auth/auth-config.ts Outdated Show resolved Hide resolved
src/auth/auth-config.ts Outdated Show resolved Hide resolved
@Xiaoshouzi-gh Xiaoshouzi-gh merged commit 35df364 into master Apr 28, 2022
@Xiaoshouzi-gh Xiaoshouzi-gh deleted the sms-region branch April 28, 2022 20:36
@Xiaoshouzi-gh Xiaoshouzi-gh restored the sms-region branch May 2, 2022 17:38
Xiaoshouzi-gh added a commit that referenced this pull request May 2, 2022
@Xiaoshouzi-gh
Revert "feat(auth): Support sms region config change on Tenant and Pr…
0080a83 
…oject level. (#1673)"

This reverts commit 35df364.
@Xiaoshouzi-gh Xiaoshouzi-gh mentioned this pull request May 2, 2022
Merged
Xiaoshouzi-gh added a commit that referenced this pull request May 2, 2022
@Xiaoshouzi-gh
Revert "feat(auth): Support sms region config change on Tenant and Pr…
abdfb00 
…oject level." (#1676)

* Revert "feat(auth): Support sms region config change on Tenant and Project level. (#1673)"

This reverts commit 35df364.

* Trigger CI
@renkelvin renkelvin mentioned this pull request Oct 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

@prameshj prameshj prameshj left review comments

@renkelvin renkelvin renkelvin approved these changes

@kevinthecheung kevinthecheung kevinthecheung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Xiaoshouzi-gh @lahirumaramba @renkelvin @kevinthecheung @prameshj