Differentiate options for sync and async SSRC initialization #2506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
It doesn't make sense to pass a cached template to
getServerTemplate
because the method loads a new template immediately.I see a recommendation to define distinct interfaces for method options: microsoft/tsdoc#19.
So, this change splits
ServerTemplateOptions
intoGetServerTemplateOptions
andInitServerTemplateOptions
.Testing
Tested with
npm test
.API Changes
Splits
ServerTemplateOptions
intoGetServerTemplateOptions
andInitServerTemplateOptions
.