Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fcm): Added support for specifying the analytics label for notifications. #597

Merged
merged 7 commits into from Aug 12, 2019
Merged

feat(fcm): Added support for specifying the analytics label for notifications. #597

merged 7 commits into from Aug 12, 2019

Conversation

@chemidy
Copy link
Contributor

@chemidy chemidy commented Jul 20, 2019

  • add analytics_label
    #580
src/messaging/messaging-types.ts Show resolved Hide resolved
Loading
@hiranya911 hiranya911 requested a review from egilmorez Jul 22, 2019
@hiranya911 hiranya911 assigned egilmorez and chemidy and unassigned egilmorez Jul 22, 2019
src/index.d.ts Outdated Show resolved Hide resolved
Loading
src/index.d.ts Outdated Show resolved Hide resolved
Loading
src/index.d.ts Outdated Show resolved Hide resolved
Loading
src/index.d.ts Outdated Show resolved Hide resolved
Loading
src/index.d.ts Outdated Show resolved Hide resolved
Loading
src/index.d.ts Outdated Show resolved Hide resolved
Loading
src/index.d.ts Outdated Show resolved Hide resolved
Loading
src/index.d.ts Outdated Show resolved Hide resolved
Loading
src/index.d.ts Outdated Show resolved Hide resolved
Loading
src/index.d.ts Outdated Show resolved Hide resolved
Loading
Copy link
Contributor

@egilmorez egilmorez left a comment

Left some style comments. Thanks for the PR!

Loading

Copy link
Contributor

@egilmorez egilmorez left a comment

index.d.ts content looks good, thanks chemidy!

Loading

Copy link
Member

@hiranya911 hiranya911 left a comment

Looks good. Just need some test cases for the new validators.

And I'm also waiting to hear from the FCM team about fcmOptions vs fcm_options in the JSON payload.

Loading

test/unit/messaging/messaging.spec.ts Show resolved Hide resolved
Loading
Copy link
Member

@hiranya911 hiranya911 left a comment

LGTM

Loading

@hiranya911 hiranya911 changed the title Analytics label feat(fcm): Added support for specifying the analytics label for notifications. Aug 12, 2019
@hiranya911 hiranya911 assigned hiranya911 and unassigned chemidy and chong-shao Aug 12, 2019
@hiranya911 hiranya911 merged commit d05dd23 into firebase:master Aug 12, 2019
4 checks passed
Loading
@chemidy chemidy deleted the analytics_label branch Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants