Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated API docs #171

Merged
merged 3 commits into from May 30, 2018
Merged

Updated API docs #171

merged 3 commits into from May 30, 2018

Conversation

hiranya911
Copy link
Contributor

Also renamed UserImportRecord to ImprotUserRecord as agreed upon in the API proposal.

go/firebase-admin-user-import

Copy link
Contributor

@avishalom avishalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -346,10 +435,26 @@ def scrypt(cls, key, rounds, memory_cost, salt_separator=None):

@classmethod
def bcrypt(cls):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be staticmethod, but good either way.

@avishalom avishalom assigned hiranya911 and unassigned avishalom May 29, 2018
@hiranya911 hiranya911 merged commit e4604da into master May 30, 2018
@hiranya911 hiranya911 deleted the hkj-update-docs branch May 30, 2018 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants