Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fcm): Added support for sending an image URL in notifications #332

Merged
merged 8 commits into from Sep 10, 2019

Conversation

@cchamm
Copy link
Contributor

commented Aug 21, 2019

Fixes #329

Cham and others added 5 commits Aug 21, 2019
@cchamm

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

Any reviewer? @hiranya911

@hiranya911

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

Hi @cchamm. Currently swamped with a couple of pending releases. Will take a look at this shortly.

@esp4ik
esp4ik approved these changes Sep 3, 2019
@hiranya911
Copy link
Member

left a comment

Looks pretty good. Just need one addition.

"""

def __init__(self, title=None, body=None, icon=None, color=None, sound=None, tag=None,
click_action=None, body_loc_key=None, body_loc_args=None, title_loc_key=None,
title_loc_args=None, channel_id=None):
title_loc_args=None, channel_id=None, image=None):

This comment has been minimized.

Copy link
@hiranya911

hiranya911 Sep 3, 2019

Member

Need the same added to APNSFCMOptions. See firebase/firebase-admin-java#298

Cham and others added 3 commits Sep 10, 2019
@esp4ik
esp4ik approved these changes Sep 10, 2019

@cchamm cchamm requested a review from hiranya911 Sep 10, 2019

@hiranya911
Copy link
Member

left a comment

LGTM. Thanks.

@hiranya911 hiranya911 assigned hiranya911 and unassigned cchamm Sep 10, 2019

@hiranya911 hiranya911 changed the title Add "image" field to AndroidNotification and Notification feat(fcm): Added support for sending an image URL in notifications Sep 10, 2019

@hiranya911 hiranya911 merged commit 0ed372e into firebase:master Sep 10, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.