Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fcm): Added support for sending an image URL in notifications #332

Merged
merged 8 commits into from Sep 10, 2019

Conversation

@cchamm
Copy link
Contributor

@cchamm cchamm commented Aug 21, 2019

Fixes #329

@cchamm
Copy link
Contributor Author

@cchamm cchamm commented Aug 26, 2019

Any reviewer? @hiranya911

Loading

@hiranya911
Copy link
Member

@hiranya911 hiranya911 commented Aug 26, 2019

Hi @cchamm. Currently swamped with a couple of pending releases. Will take a look at this shortly.

Loading

esp4ik
esp4ik approved these changes Sep 3, 2019
Copy link
Member

@hiranya911 hiranya911 left a comment

Looks pretty good. Just need one addition.

Loading

"""

def __init__(self, title=None, body=None, icon=None, color=None, sound=None, tag=None,
click_action=None, body_loc_key=None, body_loc_args=None, title_loc_key=None,
title_loc_args=None, channel_id=None):
title_loc_args=None, channel_id=None, image=None):
Copy link
Member

@hiranya911 hiranya911 Sep 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need the same added to APNSFCMOptions. See firebase/firebase-admin-java#298

Loading

esp4ik
esp4ik approved these changes Sep 10, 2019
@cchamm cchamm requested a review from hiranya911 Sep 10, 2019
Copy link
Member

@hiranya911 hiranya911 left a comment

LGTM. Thanks.

Loading

@hiranya911 hiranya911 assigned hiranya911 and unassigned cchamm Sep 10, 2019
@hiranya911 hiranya911 changed the title Add "image" field to AndroidNotification and Notification feat(fcm): Added support for sending an image URL in notifications Sep 10, 2019
@hiranya911 hiranya911 merged commit 0ed372e into firebase:master Sep 10, 2019
2 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants