-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fcm): Add send_each
and send_each_for_multicast
for FCM batch send
#706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`send_each` vs `send_all` 1. `send_each` sends one HTTP request to V1 Send endpoint for each message in the list. `send_all` sends only one HTTP request to V1 Batch Send endpoint to send all messages in the array. 2. `send_each` uses concurrent.futures.ThreadPoolExecutor to run and wait for all `request` calls to complete and construct a `BatchResponse`. An `request` call to V1 Send endpoint either completes with a success or throws an exception. So if an exception is thrown out, the exception will be caught in `send_each` and turned into a `SendResponse` with an exception. Therefore, unlike `send_all`, `send_each` does not always throw an exception for a total failure. It can also return a `BatchResponse` with only exceptions in it. `send_each_for_multicast` calls `send_each` under the hood.
* Add integration tests for send_each and send_each_for_multicast Add test_send_each, test_send_each_500 and test_send_each_for_multicast * chore: Fix pypy tests (#694) * chore(auth): Update Auth API to `v2` (#691) * `v2beta1` -> `v2` * Reverting auto formatting changes * undo auto formatting * Add release notes to project URLs in PyPI (#679) It's useful to be able to navigate to the release notes easily from the package index when upgrading. "Release Notes" is a special keyword that will have the scroll icon in the project page. A random example: * https://pypi.org/project/streamlit/ * https://github.com/streamlit/streamlit/blob/815a3ea6fa3e7f9099b479e8365bd3a5874ddc35/lib/setup.py#L111 Co-authored-by: Lahiru Maramba <llahiru@gmail.com> --------- Co-authored-by: Lahiru Maramba <llahiru@gmail.com> Co-authored-by: pragatimodi <110490169+pragatimodi@users.noreply.github.com> Co-authored-by: Samuel Dion-Girardeau <samueldg@users.noreply.github.com>
send_each
and send_each_for_multicast
for FCM batch send
kevinthecheung
approved these changes
Jun 8, 2023
send_each
and send_each_for_multicast
for FCM batch sendsend_each
and send_each_for_multicast
for FCM batch send
lahirumaramba
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
akhilnarang
added a commit
to akhilnarang/vlrgg-scraper
that referenced
this pull request
Jul 17, 2023
The latter is now deprecated: firebase/firebase-admin-python#706 Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
send_each
vssend_all
send_each
sends one HTTP request to V1 Send endpoint for each message in the list.send_all
sends only one HTTP request to V1 Batch Send endpoint to send all messages in the array.send_each
uses concurrent.futures.ThreadPoolExecutor to run and wait for allrequest
calls to complete and construct aBatchResponse
. Anrequest
call to V1 Send endpoint either completes with a success or throws an exception. So if an exception is thrown out, the exception will be caught insend_each
and turned into aSendResponse
with an exception. Therefore, unlikesend_all
,send_each
does not always throw an exception for a total failure. It can also return aBatchResponse
with only exceptions in it.send_each_for_multicast
callssend_each
under the hood.RELEASE NOTE:
send_all()
andsend_multicast()
APIs are now deprecated. Usesend_each()
andsend_each_for_multicast()
APIs instead.