Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Filter equals method. #5210

Merged
merged 3 commits into from Jul 28, 2023
Merged

Conversation

tom-andersen
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

Release note changes

The following release notes were modified. Please ensure they look correct.

Release Notes
firebase-firestore
### {{firestore}} version 24.7.0 {: #firestore_v24-7-0}

* {{feature}} Expose MultiDb support in API. GitHub [#4015](//github.com/firebase/firebase-android-sdk/issues/4015){: .external}

* {{fixed}} Fixed a thread interference issue that may lead to a ConcurrentModificationException.
    (GitHub [#5091](//github.com/firebase/firebase-android-sdk/issues/5091){: .external})

* {{fixed}} Implement equals method on Filter class. GitHub [#5210](//github.com/firebase/firebase-android-sdk/issues/5210){: .external}

#### {{firestore}} Kotlin extensions version 24.7.0 {: #firestore-ktx_v24-7-0}

The Kotlin extensions library transitively includes the updated
`firebase-firestore` library. The Kotlin extensions library has no additional
updates.

@tom-andersen tom-andersen changed the title Implement filter equals method. Implement Filter equals method. Jul 27, 2023
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 27, 2023

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.49% (824195e) to 44.63% (daf75d2) by +0.14%.

    FilenameBase (824195e)Merge (daf75d2)Diff
    Filter.java0.00%78.57%+78.57%
    SetMutation.java97.22%94.44%-2.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/uF2g4EZtxT.html

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

Unit Test Results

   164 files  +  2     164 suites  +2   3m 2s ⏱️ +57s
1 202 tests +12  1 186 ✔️ +12  16 💤 ±0  0 ±0 
2 404 runs  +24  2 372 ✔️ +24  32 💤 ±0  0 ±0 

Results for commit a23fbdc. ± Comparison against base commit c5cd536.

♻️ This comment has been updated with latest results.

@ehsannas ehsannas assigned tom-andersen and unassigned ehsannas Jul 27, 2023
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 27, 2023

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (824195e)Merge (daf75d2)Diff
    aar1.36 MB1.36 MB+637 B (+0.0%)
    apk (release)3.95 MB3.95 MB+556 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7GeH0njg5A.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 27, 2023

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentile824195edaf75d2DiffSignificant (?)
    p10321 ±22 μs313 ±17 μs-8.12 μs (-2.5%)NO
    p25333 ±26 μs324 ±20 μs-9.16 μs (-2.8%)NO
    p50349 ±32 μs349 ±51 μs-272 ns (-0.1%)NO
    p75393 ±75 μs375 ±66 μs-17.8 μs (-4.5%)NO
    p90450 ±103 μs449 ±95 μs-1.09 μs (-0.2%)NO

    20 test runs in comparison
    CommitTest Runs
    824195e
    • 2023-07-28_03:35:35.982214_AWxO
    • 2023-07-28_03:35:35.985616_luuq
    • 2023-07-28_03:35:35.985627_ngKl
    • 2023-07-28_03:35:35.985634_KfiG
    • 2023-07-28_03:35:35.985639_OTOo
    • 2023-07-28_03:35:35.985645_fqMS
    • 2023-07-28_03:35:35.985650_CtJY
    • 2023-07-28_03:35:35.985655_toOT
    • 2023-07-28_03:35:35.985660_OEas
    • 2023-07-28_03:35:35.985666_dAGt
    daf75d2
    • 2023-07-28_14:21:23.622031_nXXT
    • 2023-07-28_14:21:23.632517_Slsk
    • 2023-07-28_14:21:23.632537_lxpx
    • 2023-07-28_14:21:23.632545_HjNg
    • 2023-07-28_14:21:23.632557_rRbp
    • 2023-07-28_14:21:23.632564_eLtL
    • 2023-07-28_14:21:23.632570_GUIm
    • 2023-07-28_14:21:23.632825_oxKG
    • 2023-07-28_14:21:23.633106_PzVm
    • 2023-07-28_14:21:23.633327_drUk
    redfin-30
    Percentile824195edaf75d2DiffSignificant (?)
    p10600 ±27 μs596 ±34 μs-3.44 μs (-0.6%)NO
    p25620 ±28 μs611 ±40 μs-9.67 μs (-1.6%)NO
    p50646 ±36 μs633 ±48 μs-13.4 μs (-2.1%)NO
    p75682 ±47 μs665 ±61 μs-17.1 μs (-2.5%)NO
    p90734 ±74 μs713 ±93 μs-20.7 μs (-2.8%)NO

    20 test runs in comparison
    CommitTest Runs
    824195e
    • 2023-07-28_03:35:35.982214_AWxO
    • 2023-07-28_03:35:35.985616_luuq
    • 2023-07-28_03:35:35.985627_ngKl
    • 2023-07-28_03:35:35.985634_KfiG
    • 2023-07-28_03:35:35.985639_OTOo
    • 2023-07-28_03:35:35.985645_fqMS
    • 2023-07-28_03:35:35.985650_CtJY
    • 2023-07-28_03:35:35.985655_toOT
    • 2023-07-28_03:35:35.985660_OEas
    • 2023-07-28_03:35:35.985666_dAGt
    daf75d2
    • 2023-07-28_14:21:23.622031_nXXT
    • 2023-07-28_14:21:23.632517_Slsk
    • 2023-07-28_14:21:23.632537_lxpx
    • 2023-07-28_14:21:23.632545_HjNg
    • 2023-07-28_14:21:23.632557_rRbp
    • 2023-07-28_14:21:23.632564_eLtL
    • 2023-07-28_14:21:23.632570_GUIm
    • 2023-07-28_14:21:23.632825_oxKG
    • 2023-07-28_14:21:23.633106_PzVm
    • 2023-07-28_14:21:23.633327_drUk
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile824195edaf75d2DiffSignificant (?)
    p10199 ±4 ms202 ±3 ms+3.08 ms (+1.6%)NO
    p25205 ±6 ms208 ±2 ms+2.56 ms (+1.2%)NO
    p50212 ±5 ms215 ±2 ms+2.95 ms (+1.4%)NO
    p75221 ±5 ms225 ±3 ms+3.87 ms (+1.8%)NO
    p90229 ±6 ms238 ±12 ms+8.78 ms (+3.8%)NO

    20 test runs in comparison
    CommitTest Runs
    824195e
    • 2023-07-28_03:35:35.982214_AWxO
    • 2023-07-28_03:35:35.985616_luuq
    • 2023-07-28_03:35:35.985627_ngKl
    • 2023-07-28_03:35:35.985634_KfiG
    • 2023-07-28_03:35:35.985639_OTOo
    • 2023-07-28_03:35:35.985645_fqMS
    • 2023-07-28_03:35:35.985650_CtJY
    • 2023-07-28_03:35:35.985655_toOT
    • 2023-07-28_03:35:35.985660_OEas
    • 2023-07-28_03:35:35.985666_dAGt
    daf75d2
    • 2023-07-28_14:21:23.622031_nXXT
    • 2023-07-28_14:21:23.632517_Slsk
    • 2023-07-28_14:21:23.632537_lxpx
    • 2023-07-28_14:21:23.632545_HjNg
    • 2023-07-28_14:21:23.632557_rRbp
    • 2023-07-28_14:21:23.632564_eLtL
    • 2023-07-28_14:21:23.632570_GUIm
    • 2023-07-28_14:21:23.632825_oxKG
    • 2023-07-28_14:21:23.633106_PzVm
    • 2023-07-28_14:21:23.633327_drUk
    redfin-30
    Percentile824195edaf75d2DiffSignificant (?)
    p10244 ±3 ms267 ±4 ms+23.3 ms (+9.5%)YES
    p25251 ±4 ms274 ±5 ms+23.1 ms (+9.2%)YES
    p50258 ±4 ms282 ±5 ms+23.6 ms (+9.1%)YES
    p75267 ±5 ms291 ±5 ms+24.5 ms (+9.2%)MAYBE
    p90278 ±6 ms306 ±8 ms+28.2 ms (+10.1%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    824195e
    • 2023-07-28_03:35:35.982214_AWxO
    • 2023-07-28_03:35:35.985616_luuq
    • 2023-07-28_03:35:35.985627_ngKl
    • 2023-07-28_03:35:35.985634_KfiG
    • 2023-07-28_03:35:35.985639_OTOo
    • 2023-07-28_03:35:35.985645_fqMS
    • 2023-07-28_03:35:35.985650_CtJY
    • 2023-07-28_03:35:35.985655_toOT
    • 2023-07-28_03:35:35.985660_OEas
    • 2023-07-28_03:35:35.985666_dAGt
    daf75d2
    • 2023-07-28_14:21:23.622031_nXXT
    • 2023-07-28_14:21:23.632517_Slsk
    • 2023-07-28_14:21:23.632537_lxpx
    • 2023-07-28_14:21:23.632545_HjNg
    • 2023-07-28_14:21:23.632557_rRbp
    • 2023-07-28_14:21:23.632564_eLtL
    • 2023-07-28_14:21:23.632570_GUIm
    • 2023-07-28_14:21:23.632825_oxKG
    • 2023-07-28_14:21:23.633106_PzVm
    • 2023-07-28_14:21:23.633327_drUk

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/1XBaLiFcUv/index.html

@ehsannas ehsannas removed their assignment Jul 28, 2023
@tom-andersen tom-andersen merged commit 622d65b into master Jul 28, 2023
19 checks passed
@tom-andersen tom-andersen deleted the tomandersen/filterEquals branch July 28, 2023 21:34
davidmotson pushed a commit that referenced this pull request Aug 3, 2023
* Implement filter equals method.

* Add changelog entry

* Fix format and PR feedback
@firebase firebase locked and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants