-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata for firebase-crashlytics-gradle
version 3.0.0
is missing the dependencies on
#5929
Comments
I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight. |
Once I have updated to firebase-crashlytics 3.0.0, I keep getting this error |
Hi @yogurtearl, thank you for reaching out and reporting the issue. I tried reproducing the issue, however, I’m having a hard time in replicating it. Is there any chance you could share an MCVE to help us investigate the issue? You mentioned that this is similar #5473. It’s possible that the cause is similar to #5473 (comment). Let me check this with our engineer. |
Hi @Ma7moud3ly. The error you're experiencing is related to this issue. The fix has not been released yet as per #5925 (comment). You can try the latest changes from the pre-release build #5733. |
@yogurtearl can you please explain a little bit why you setup the plugin like this? In the other issue, you mentioned a build script. But I still don't understand why you define the dependencies like this, instead of in the Also, what version of the Android Gradle plugin do you use? You should get a much more friendly error message with a link to documentation in it. |
Using AGP 8.4.0 in this example. If I want to create a plugin that applies the firebase crashlytics gradle plugin and does some additional config, I need to add the firebase crashlytics plugin as a dependency. Is there a downside for firebase crashlytics gradle plugin correctly declaring all of its dependencies in the meta-data? |
Hey @yogurtearl we released version |
@rlazo I confirm it works. I was awaiting for this one but my dependency manager did not warn me about 3.0.1 The reason is I usually use the same version variable for |
Thanks for the confirmation! |
[READ] Step 1: Are you in the right place?
yes
[REQUIRED] Step 2: Describe your environment
firebase-crashlytics-gradle
3.0.0
(was working in2.9.9
[REQUIRED] Step 3: Describe the problem
Steps to reproduce:
Create a small gradle plugin that relies on the firebase crashlytics gradle plugin (see code below)
3.0.0
seems to have added a reference tocom.android.build.api.variant.ApplicationAndroidComponentsExtension
in the file
com.google.firebase.crashlytics.buildtools.gradle.CrashlyticsPlugin
but it didn't add the needed dependency in the published
.pom
file or the.module
file.Those files should declare dependencies on all other things that are in use.
in this case, they need to have a dependency on
com.android.tools.build:gradle-api
Relevant Code:
in
src/main/kotlin/firebase-crashlytics.gradle.kts
in
build.gradle.kts
Context:
This is similar to this issue: #5473
workaround
add this to the
build.gradle.kts
file of your plugin that depends on the firebase crashlytics plugin:implementation("com.android.tools.build:gradle-api:8.4.0")
The text was updated successfully, but these errors were encountered: