Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: Fix global refs exhaustion issue in Android #1364

Merged
merged 5 commits into from
Jun 30, 2023
Merged

Firestore: Fix global refs exhaustion issue in Android #1364

merged 5 commits into from
Jun 30, 2023

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Jun 27, 2023 •
edited
Loading

Properly fix the the global refs exhaustion issue tracked by firebase/firebase-unity-sdk#569, and reported in firebase/quickstart-unity#1303 and firebase/quickstart-unity#1193 (comment) (Googlers see b/251869890 for more details). Part 1, a partial mitigation, was #1111.

This PR supersedes, and builds upon the work done by @cherylEnkidu in, #1176.

Googlers see go/firestore-cpp-sdk-android-global-ref-exhaustion-bug and b/251869890 for more information.

@dconeybe dconeybe self-assigned this Jun 27, 2023
@dconeybe dconeybe mentioned this pull request Jun 27, 2023
Closed
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label Jun 27, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 27, 2023
@github-actions
Copy link

github-actions bot commented Jun 27, 2023 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @dconeybe on commit f2f99bb
Last updated: Fri Jun 30 14:35 PDT 2023
View integration test log & download artifacts

Failures Configs
app_check [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT
firestore [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(2 failed tests)  ServerTimestampTest.TestServerTimestampsUsesPreviousValueFromLocalMutation
  SourceTest.GetNonExistingCollectionWhileOnlineWithDefaultGetOptions
gma [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 27, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 27, 2023
@dconeybe dconeybe requested a review from wu-hui June 27, 2023 19:12
wu-hui
wu-hui approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an impressive PR, I love how organized it is.

I left couple comments on potential improvements in some code comments, but LGTM overall, nice work!

firestore/src_java/com/google/firebase/firestore/internal/cpp/ObjectArena.java Outdated Show resolved Hide resolved
firestore/src_java/com/google/firebase/firestore/internal/cpp/ObjectArena.java Outdated Show resolved Hide resolved
firestore/src/jni/arena_ref.h Show resolved Hide resolved
@dconeybe dconeybe added tests-requested: quick Trigger a quick set of integration tests. and removed tests: succeeded This PR's integration tests succeeded. labels Jun 30, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 30, 2023
@dconeybe dconeybe requested a review from wu-hui June 30, 2023 16:08
@dconeybe dconeybe added tests-requested: quick Trigger a quick set of integration tests. and removed tests: in-progress This PR's integration tests are in progress. labels Jun 30, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 30, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 30, 2023
@dconeybe dconeybe merged commit f2f99bb into main Jun 30, 2023
58 of 60 checks passed
@dconeybe dconeybe deleted the dconeybe/ArenaRef2 branch June 30, 2023 18:55
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Jun 30, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 30, 2023
@dconeybe dconeybe mentioned this pull request Jul 4, 2023
Merged
tom-andersen pushed a commit that referenced this pull request Jul 17, 2023
@dconeybe @tom-andersen
Firestore: Fix global refs exhaustion issue in Android (#1364)
89a6381
@dconeybe dconeybe mentioned this pull request Jul 18, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@wu-hui wu-hui

@dconeybe dconeybe

Labels
api: firestore tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dconeybe @wu-hui