Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update minimum CMake version to 3.5 #1617

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Lyokone
Copy link

@Lyokone Lyokone commented Jun 26, 2024

Description

Provide details of the change, and generalize the change in the PR title above.

Updates the CMake version to 3.5.
closes #1599


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Manually tested by compiling firebase cpp sdk with FlutterFire.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@cynthiajoan
Copy link
Contributor

Do we also want to update the cmake min version for all integration_test within this PR? @jonsimantov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Update the minimum required CMake version
2 participants