Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly convert milliseconds to seconds #767

Merged
merged 5 commits into from
Dec 2, 2021
Merged

Properly convert milliseconds to seconds #767

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
68d9eda
Properly convert milliseconds to seconds
pawelsnk Nov 30, 2021
80fb7e2
Update readme.md
pawelsnk Dec 1, 2021
473b159
Update readme.md
pawelsnk Dec 1, 2021
cddd572
Fix indentation in readme.
pawelsnk Dec 2, 2021
e6847a6
Fix case in readme
pawelsnk Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions release_build_files/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,9 @@ code.
([#745](https://github.com/firebase/firebase-cpp-sdk/pull/745))
- Messaging (Android): Fixed crash during initialization.
([#760](https://github.com/firebase/firebase-cpp-sdk/pull/760))
- Remote config (Desktop): Fixed cache expiration time value used by
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the indents to match the above lines? (4 spaces before the hyphen then 3 spaces after the hyphen; on the following lines, 8 space indent, no tabs). Also could you fix the capitalization to "Remote Config"?

Thanks!

`RemoteConfig::FetchAndActivate()`.
([#767](https://github.com/firebase/firebase-cpp-sdk/pull/767))


### 8.7.0
Expand Down
3 changes: 2 additions & 1 deletion remote_config/src/desktop/remote_config_desktop.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,8 @@ Future<bool> RemoteConfigInternal::FetchAndActivate() {
future_impl_.SafeAlloc<bool>(kRemoteConfigFnFetchAndActivate);

cache_expiration_in_seconds_ =
config_settings_.minimum_fetch_interval_in_milliseconds;
config_settings_.minimum_fetch_interval_in_milliseconds /
::firebase::internal::kMillisecondsPerSecond;

uint64_t milliseconds_since_epoch =
std::chrono::duration_cast<std::chrono::milliseconds>(
Expand Down