-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: storage module #13
Conversation
Tested storage, here're results: Function code: from firebase_functions import storage
from firebase_functions.storage import StorageObjectData, CloudEvent
from firebase_admin import initialize_app
initialize_app()
@storage.on_object_finalized(bucket="python-functions-testing.appspot.com")
def on_object_finalized_example(event: CloudEvent[StorageObjectData]):
print(event) One note tho: |
will add in another PR
This is the bucket name without any prefixes or additions (without "gs://"). | ||
""" | ||
|
||
# TODO more to be added later when they are required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taeold FYI - left this as a TODO since none of the others were needed yet - thought it best to add them when they're required - is that ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd maybe add databaseURL here, but fair with me if you want to tackle it later.
This is the bucket name without any prefixes or additions (without "gs://"). | ||
""" | ||
|
||
# TODO more to be added later when they are required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd maybe add databaseURL here, but fair with me if you want to tackle it later.
See next comment for testing results.
Note: this PR also breaks out the example/ into multiple sample projects into
samples/
for ease of deploying/testing functions specific to a module/service and for a later date for user samples.