Don't delete fields on a non-breaking change release (#1238)

firebase · Sep 21, 2022 · b93e397 · b93e397
1 parent 65e66a2
commit b93e397
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/spec/v2/providers/alerts/alerts.spec.ts b/spec/v2/providers/alerts/alerts.spec.ts
@@ -205,6 +205,8 @@ describe('alerts', () => {
 
       expect(converted).to.deep.eq({
         ...event,
+        alerttype: 'my-alert',
+        appid: 'my-app',
         alertType: 'my-alert',
         appId: 'my-app',
       });

diff --git a/src/v2/providers/alerts/alerts.ts b/src/v2/providers/alerts/alerts.ts
@@ -283,11 +283,9 @@ export function convertAlertAndApp(
 
   if ('alerttype' in event) {
     (event as any).alertType = (event as any).alerttype;
-    delete (event as any).alerttype;
   }
   if ('appid' in event) {
     (event as any).appId = (event as any).appid;
-    delete (event as any).appid;
   }
 
   return event;