Enhance RTDB v2 Triggers #1153
Enhance RTDB v2 Triggers #1153
Conversation
|
@taeold Good point, I know we duplicated a bunch of the Event Handler options for better docs so I thought we should also do that here. Ended up moving it the common code path |
src/providers/database.ts
Outdated
| import { DataSnapshot } from '../common/providers/database'; | ||
| import { firebaseConfig } from '../config'; | ||
| import { DeploymentOptions } from '../function-configuration'; | ||
| import { normalizePath } from '../utilities/path'; | ||
| import { applyChange } from '../utils'; | ||
|
|
||
| export { DataSnapshot }; | ||
| export { DataSnapshot, Change }; |
There was a problem hiding this comment.
I don't think we actually exported Change from the RDTB namespace in the past, did we? IIRC it was just exported in index.ts. We should put it in v1/index.ts and v2/index.ts as well as v2/core.ts
There was a problem hiding this comment.
sounds good, I'll wait for the other PRs to complete first
| /** | ||
| * `ChangeJson` is the JSON format used to construct a Change object. | ||
| */ | ||
| export interface ChangeJson { |
There was a problem hiding this comment.
Should this be @internal? Are users actually constructing a ChangeJson?
|
Trying to make sure we get this in, sync |
This commit resolves faulty merge-conflicted code that did not take into account the changes from #1153.
Changefromcommon/change.tssince we're using it in both v1 & v2 functionsreinterpretCastfromChangenamespaceonValue*