Fix bug where auth metadata in the auth blocking tokens are assumed to be seconds not miliseconds #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o be seconds not miliseconds.
joehan
approved these changes
Oct 19, 2023
This was referenced May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auth metadata included in the JWT sent to Auth Blocking functions may include fields
last_sign_in_timeandcreation_time.Values of these fields are sent as miliseconds since epoch. The SDK incorrectly assumes that they are seconds since epoch.
Unfortunately, this information is not publicly documented, but I was able to verify the fix in production.
Fixes: #1468