Update with new API

firebase · Jul 29, 2020 · 740d830 · 740d830
1 parent ed4b3d5
commit 740d830
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/FirebaseCore/Sources/FIREmulatorSettings.m b/FirebaseCore/Sources/FIREmulatorSettings.m
@@ -93,16 +93,24 @@ - (instancetype)settingsByRemovingSettingsForService:(FIREmulatorService)service
 - (instancetype)settingsByAddingSettings:(FIREmulatorServiceSettings *)settings 
                               forService:(FIREmulatorService)service {
   NSMutableDictionary *mutableSettings = [self.settings mutableCopy];
-  [mutableSettings addObject:settings];
+  [mutableSettings setObject:settings forKey:service];
   return [[FIREmulatorSettings alloc] initWithSettings:mutableSettings];
 }
 
+- (instancetype)settingsByAddingSettingsWithHost:(NSString *)host
+                                            port:(NSInteger)port 
+                                      forService:(FIREmulatorService)service {
+  FIREmulatorServiceSettings *settings =
+      [[FIREmulatorServiceSettings alloc] initWithHost:host port:port];
+  return [self settingsByAddingSettings:settings forService:service];
+}
+
 - (NSDictionary *)getAllServiceSettings {
   return [self.settings copy];
 }
 
 - (instancetype)copyWithZone:(NSZone *)zone {
-  return self;  // immutable, so return self
+  return self; // immutable, so return self
 }
 
 - (FIREmulatorServiceSettings *)settingsForService:(FIREmulatorService)service {

diff --git a/FirebaseCore/Sources/Public/FIREmulatorSettings.h b/FirebaseCore/Sources/Public/FIREmulatorSettings.h
@@ -77,10 +77,16 @@ NS_SWIFT_NAME(EmulatorSettings)
 - (instancetype)settingsByRemovingSettingsForService:(FIREmulatorService)service;
 
 /// Returns a new settings object that is the result of adding new settings for a given
-/// service.
+/// service. Overwrites a pre-existing settings entry for the given key, if it exists.
 - (instancetype)settingsByAddingSettings:(FIREmulatorServiceSettings *)settings 
                               forService:(FIREmulatorService)service
 
+/// Returns a new settings object that is the result of adding new settings for a given
+/// service. Overwrites a pre-existing settings entry for the given key, if it exists.
+- (instancetype)settingsByAddingSettingsWithHost:(NSString *)host
+                                            port:(NSInteger)port 
+                                      forService:(FIREmulatorService)service;
+
 /// Returns the service-level settings object for a given emulated service, if it exists.
 - (FIREmulatorServiceSettings *_Nullable)settingsForService:(FIREmulatorService)service;