Skip to content

Commit

Permalink
[Rollouts] Revert constants change in remote config public api test (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
ddnan authored and themiswang committed Mar 11, 2024
1 parent 1e3b0e8 commit 98ecf0e
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 1 deletion.
21 changes: 21 additions & 0 deletions FirebaseRemoteConfig/Sources/RCNConstants3P.m
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
/*
* Copyright 2019 Google
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

#import "FirebaseRemoteConfig/Sources/Public/FirebaseRemoteConfig/FIRRemoteConfig.h"

/// Firebase Remote Config service default namespace.
/// TODO(doudounan): Change to use this namespace defined in RemoteConfigInterop.
NSString *const FIRNamespaceGoogleMobilePlatform = @"firebase";
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ final class FirebaseRemoteConfigSwift_APIBuildTests: XCTestCase {
// MARK: - FirebaseRemoteConfig

// TODO(ncooke3): These global constants should be lowercase.
let _: String = RemoteConfigConstants.NamespaceGoogleMobilePlatform
let _: String = FirebaseRemoteConfig.NamespaceGoogleMobilePlatform
let _: String = FirebaseRemoteConfig.RemoteConfigThrottledEndTimeInSecondsKey

// TODO(ncooke3): This should probably not be initializable.
Expand Down

0 comments on commit 98ecf0e

Please sign in to comment.