Begin migrating FIRLoggerService declarations to clients (#2720)

Example/Core/Tests/FIRLoggerTest.m

@@ -76,15 +76,9 @@ - (void)testStableVariables {
   XCTAssertEqualObjects(kFIRLoggerABTesting, @"[Firebase/ABTesting]");
   XCTAssertEqualObjects(kFIRLoggerAdMob, @"[Firebase/AdMob]");
   XCTAssertEqualObjects(kFIRLoggerAnalytics, @"[Firebase/Analytics]");
-  XCTAssertEqualObjects(kFIRLoggerAuth, @"[Firebase/Auth]");
   XCTAssertEqualObjects(kFIRLoggerCore, @"[Firebase/Core]");
-  XCTAssertEqualObjects(kFIRLoggerDatabase, @"[Firebase/Database]");
-  XCTAssertEqualObjects(kFIRLoggerDynamicLinks, @"[Firebase/DynamicLinks]");
-  XCTAssertEqualObjects(kFIRLoggerInstanceID, @"[Firebase/InstanceID]");
   XCTAssertEqualObjects(kFIRLoggerMLKit, @"[Firebase/MLKit]");
-  XCTAssertEqualObjects(kFIRLoggerMessaging, @"[Firebase/Messaging]");
   XCTAssertEqualObjects(kFIRLoggerRemoteConfig, @"[Firebase/RemoteConfig]");
-  XCTAssertEqualObjects(kFIRLoggerStorage, @"[Firebase/Storage]");
 }
 
 - (void)testInitializeASLForNonDebugMode {

Example/Podfile

@@ -19,7 +19,7 @@ target 'Core_Example_iOS' do
   # The next line is the forcing function for the Firebase pod. The Firebase
   # version's subspecs should depend on the component versions in their
   # corresponding podspec's.
-  pod 'Firebase/CoreOnly', '5.20.990'
+  pod 'Firebase/CoreOnly', '5.20.991'
 
   target 'Core_Tests_iOS' do
     inherit! :search_paths

Firebase/Core/FIRLogger.m

@@ -20,21 +20,16 @@
 
 #import "Private/FIRVersion.h"
 
+FIRLoggerService kFIRLoggerCore = @"[Firebase/Core]";
+
+// All the FIRLoggerService definitions should be migrated to clients. Do not add new ones!
 FIRLoggerService kFIRLoggerABTesting = @"[Firebase/ABTesting]";
 FIRLoggerService kFIRLoggerAdMob = @"[Firebase/AdMob]";
 FIRLoggerService kFIRLoggerAnalytics = @"[Firebase/Analytics]";
 FIRLoggerService kFIRLoggerAuth = @"[Firebase/Auth]";
-FIRLoggerService kFIRLoggerCore = @"[Firebase/Core]";
-FIRLoggerService kFIRLoggerDatabase = @"[Firebase/Database]";
-FIRLoggerService kFIRLoggerDynamicLinks = @"[Firebase/DynamicLinks]";
-FIRLoggerService kFIRLoggerFirestore = @"[Firebase/Firestore]";
-FIRLoggerService kFIRLoggerInstanceID = @"[Firebase/InstanceID]";
 FIRLoggerService kFIRLoggerMLKit = @"[Firebase/MLKit]";
-FIRLoggerService kFIRLoggerMessaging = @"[Firebase/Messaging]";
 FIRLoggerService kFIRLoggerPerf = @"[Firebase/Performance]";
 FIRLoggerService kFIRLoggerRemoteConfig = @"[Firebase/RemoteConfig]";
-FIRLoggerService kFIRLoggerStorage = @"[Firebase/Storage]";
-FIRLoggerService kFIRLoggerSwizzler = @"[FirebaseSwizzlingUtilities]";
 
 /// Arguments passed on launch.
 NSString *const kFIRDisableDebugModeApplicationArgument = @"-FIRDebugDisabled";

Firebase/Core/Private/FIRLogger.h

@@ -30,16 +30,9 @@ extern FIRLoggerService kFIRLoggerAdMob;
 extern FIRLoggerService kFIRLoggerAnalytics;
 extern FIRLoggerService kFIRLoggerAuth;
 extern FIRLoggerService kFIRLoggerCore;
-extern FIRLoggerService kFIRLoggerDatabase;
-extern FIRLoggerService kFIRLoggerDynamicLinks;
-extern FIRLoggerService kFIRLoggerFirestore;
-extern FIRLoggerService kFIRLoggerInstanceID;
 extern FIRLoggerService kFIRLoggerMLKit;
-extern FIRLoggerService kFIRLoggerMessaging;
 extern FIRLoggerService kFIRLoggerPerf;
 extern FIRLoggerService kFIRLoggerRemoteConfig;
-extern FIRLoggerService kFIRLoggerStorage;
-extern FIRLoggerService kFIRLoggerSwizzler;
 
 /**
  * The key used to store the logger's error count.

Firebase/Database/Utilities/FUtilities.h

@@ -15,6 +15,8 @@
  */
 
 #import <Foundation/Foundation.h>
+#import <FirebaseCore/FIRLogger.h>
+
 #import "FParsedUrl.h"
 
 @interface FUtilities : NSObject
@@ -70,6 +72,7 @@ FOUNDATION_EXPORT NSString *const kFPersistenceLogTag;
   } \
 } while(0)
 
+extern FIRLoggerService kFIRLoggerDatabase;
 BOOL FFIsLoggingEnabled(FLogLevel logLevel);
 void firebaseUncaughtExceptionHandler(NSException *exception);
 void firebaseJobsTroll(void);

Firebase/Database/Utilities/FUtilities.m

@@ -27,6 +27,7 @@
 #pragma mark -
 #pragma mark C functions
 
+FIRLoggerService kFIRLoggerDatabase = @"[Firebase/Database]";
 static FLogLevel logLevel = FLogLevelInfo; // Default log level is info
 static NSMutableDictionary* options = nil;
 

Firebase/DynamicLinks/Logging/FDLLogging.m

@@ -18,6 +18,8 @@
 
 #ifdef GIN_SCION_LOGGING
 #import <FirebaseCore/FIRLogger.h>
+
+FIRLoggerService kFIRLoggerDynamicLinks = @"[Firebase/DynamicLinks]";
 #endif  // GIN_SCION_LOGGING
 
 #ifdef GIN_SCION_LOGGING

Firebase/Messaging/FIRMessagingLogger.m

@@ -18,6 +18,8 @@
 
 #import <FirebaseCore/FIRLogger.h>
 
+FIRLoggerService kFIRLoggerMessaging = @"[Firebase/Messaging]";
+
 @implementation FIRMessagingLogger
 
 + (instancetype)standardLogger {

FirebaseCore.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name             = 'FirebaseCore'
-  s.version          = '5.4.90'
+  s.version          = '5.4.91'
   s.summary          = 'Firebase Core for iOS (plus community support for macOS and tvOS)'
 
   s.description      = <<-DESC

Firestore/Example/Podfile

@@ -14,7 +14,7 @@ target 'Firestore_Example_iOS' do
   # The next line is the forcing function for the Firebase pod. The Firebase
   # version's subspecs should depend on the component versions in their
   # corresponding podspec's.
-  pod 'Firebase/CoreOnly', '5.20.990'
+  pod 'Firebase/CoreOnly', '5.20.991'
 
   pod 'FirebaseAuth', :path => '../../'
   pod 'FirebaseAuthInterop', :path => '../../'

Firestore/core/src/firebase/firestore/util/log_apple.mm

@@ -32,6 +32,8 @@
 
 namespace {
 
+const FIRLoggerService kFIRLoggerFirestore = @"[Firebase/Firestore]";
+
 // Translates a C++ LogLevel to the equivalent Objective-C FIRLoggerLevel
 FIRLoggerLevel ToFIRLoggerLevel(LogLevel level) {
   switch (level) {