Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing for "gRPC-C++-gRPCCertificates-Cpp" requires a development team with KMP and Cocoapods integration #10411

Closed
mpivchev opened this issue Oct 26, 2022 · 6 comments

Comments

@mpivchev
Copy link

Description

I have the following cocoapods integration section in my shared code build.gradle. This is part of the CocoaPods integration with KMM

  cocoapods {
        summary = ""
        homepage = ""
        framework {
            baseName = "shared"
            export(libs.koin.core.get())
            export(libs.napier.get())
        }
        pod("FirebaseFirestore") {
            version = "10.0.0"
            git("https://github.com/firebase/firebase-ios-sdk.git")
        }
        ios.deploymentTarget = "16.0"
    }

It's not possible for me to sign this target, as the Pods project is always regenerated on every build/run.

What I tried:

  • Signing manually inside {SHARED_FOLDER}/build/cocoapods/synthethic/IOS. It gets reset on every build/run.
  • Adding this piece of code to the podfile inside the above-mentioned path. It gets reset on every build/run:
post_install do |installer|
  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      if target.respond_to?(:product_type) and target.product_type == "com.apple.product-type.bundle"
        target.build_configurations.each do |config|
            config.build_settings['CODE_SIGNING_ALLOWED'] = 'NO'
        end
      end
    end
  end
end

Reproducing the issue

No response

Firebase SDK Version

10.0.0

Xcode Version

14.0.1

Installation Method

CocoaPods

Firebase Product(s)

Firestore

Targeted Platforms

iOS

Relevant Log Output

...shared/build/cocoapods/synthetic/IOS/Pods/Pods.xcodeproj: error: Signing for "gRPC-C++-gRPCCertificates-Cpp" requires a development team. Select a development team in the Signing & Capabilities editor. (in target 'gRPC-C++-gRPCCertificates-Cpp' from project 'Pods')

If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet
Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet
Replace this line with the contents of your Podfile.lock!
@google-oss-bot
Copy link

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@paulb777
Copy link
Member

Please report to the KMP project. The gRPC-C++-gRPCCertificates-Cpp file is no longer required for Firestore.

@mpivchev
Copy link
Author

@paulb777 So it's a KMP issue? The gRPC-C++-gRPCCertificates-Cpp is bundled with this lib...

@paulb777
Copy link
Member

gRPC-C++-gRPCCertificates-Cpp comes bundled with the gRPC dependency of Firestore. However, Firestore does not need it.

@mpivchev
Copy link
Author

mpivchev commented Oct 27, 2022

Here #9184 (comment) you mention that the zip builder can have a special case to not build this bundle. Has this been added? If not, can you give me some hints of possible ways to do this? Thanks.

@mpivchev
Copy link
Author

@firebase firebase locked and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants