Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is gRPCCertificates-Cpp.bundle necessary? #9184

Closed
paulb777 opened this issue Jan 8, 2022 Discussed in #9183 · 2 comments · Fixed by #12821
Closed

Is gRPCCertificates-Cpp.bundle necessary? #9184

paulb777 opened this issue Jan 8, 2022 Discussed in #9183 · 2 comments · Fixed by #12821
Assignees
Labels
api: firestore zip Issues related to binary distribution (zip file) zip-builder Tools related to building the zip file.

Comments

@paulb777
Copy link
Member

paulb777 commented Jan 8, 2022

Discussed in #9183

Originally posted by uhooi January 7, 2022
Firebase.zip contains Firebase/FirebaseFirestore/Resources/gRPCCertificates-Cpp.bundle.
https://github.com/firebase/firebase-ios-sdk/releases/tag/v8.10.0

But, I think it is no longer needed since 6.13.0.
https://firebase.google.com/support/release-notes/ios#cloud-firestore_35

Why is gRPCCertificates-Cpp.bundle still included in the release?
If it is not needed, please remove it as it is confusing.


  • Firebase SDK version: 8.10.0
@paulb777
Copy link
Member Author

paulb777 commented Jan 8, 2022

gRPC continues to include gRPCCertificates-Cpp.bundle even though Firestore no longer needs it, so our zip builder tooling includes it when creating the distribution.

I'll create this issue to add a special case to the zip builder to prevent resource creation for Firestore.

In the meantime, it's safe to disregard gRPCCertificates-Cpp.bundle.

@paulb777 paulb777 added zip-builder Tools related to building the zip file. zip Issues related to binary distribution (zip file) api: firestore labels Jan 8, 2022
@uhooi
Copy link

uhooi commented Jan 8, 2022

Thanks for the quick answer!
I ignore the gRPCCertificates-Cpp.bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore zip Issues related to binary distribution (zip file) zip-builder Tools related to building the zip file.
Projects
None yet
3 participants