Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Performance unit tests on Xcode 15 #11903

Open
paulb777 opened this issue Oct 6, 2023 · 5 comments
Open

Fix Performance unit tests on Xcode 15 #11903

paulb777 opened this issue Oct 6, 2023 · 5 comments

Comments

@paulb777
Copy link
Member

paulb777 commented Oct 6, 2023

Description

The Performance unit tests should run from Xcode 15

Reproducing the issue

bundle exec pod gen FirebasePerformance.podspec --auto-open --local-sources=./ --platforms=ios
Select the unit test scheme and tes:

Screenshot 2023-10-06 at 10 36 01 AM

Firebase SDK Version

10.16.0

Xcode Version

15

Installation Method

CocoaPods

Firebase Product(s)

Performance

Targeted Platforms

iOS

Relevant Log Output

No response

If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet
Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet
Replace this line with the contents of your Podfile.lock!
@paulb777
Copy link
Member Author

paulb777 commented Nov 2, 2023

Interestingly, only one test fails running via SPM:

-[FPRObjectInstrumentorTest testCopySelectorFromClassThatModifies]

@paulb777
Copy link
Member Author

Also GCDWebServer needs to be removed or have its minimum iOS version updated.

Screenshot 2024-03-29 at 5 07 27 PM

@ncooke3
Copy link
Member

ncooke3 commented Apr 11, 2024

Also GCDWebServer needs to be removed or have its minimum iOS version updated.

Screenshot 2024-03-29 at 5 07 27 PM

Could we stage a modified version of the pod on SpecStaging?

@paulb777
Copy link
Member Author

That's a good idea, at least for a workaround - since we don't necessarily need to support our customers using testspecs.

@paulb777
Copy link
Member Author

With firebase/SpecsStaging@3cfca36, I get a successful build, but still see 48 test failures:

Screenshot 2024-04-11 at 3 43 31 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants