Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix perf unit tests somehow #12088

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Fix perf unit tests somehow #12088

merged 3 commits into from
Nov 10, 2023

Conversation

morganchen12
Copy link
Contributor

@morganchen12 morganchen12 commented Nov 9, 2023

Changing the order of these reads reliably prevents a crash when running the test. Never figured out the origin but the crash also does not occur with the original order when zombies are enabled, so it's likely related to the dealloc code in swizzled objects.

The crash occurs in objc_release and may be a real production crash affecting users.

#no-changelog

Related to #11903 but does not resolve it.

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebasePerformance-iOS-FirebasePerformance.framework

    Overall coverage changed from 94.76% (08733c4) to 94.71% (d8b6d8d) by -0.05%.

    FilenameBase (08733c4)Merge (d8b6d8d)Diff
    FPRGaugeManager.m97.39%95.42%-1.96%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Z2rzraZitg.html

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@morganchen12 morganchen12 merged commit 51e20fd into master Nov 10, 2023
51 checks passed
@morganchen12 morganchen12 deleted the mc/units branch November 10, 2023 18:01
@firebase firebase locked and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants