-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation failing since the last Promises update #12427
Comments
I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight. |
Faced the same issue using Had to force Promises back to |
@mojidabckuu Yes, I've done the same thing for now. |
Hmm, I'm not able to reproduce, and looking at the Promises diffs from 2.3.1 to 2.4.0, there is only the addition of the privacy manifest and a bump of the Swift version to 5.3. I'm not sure why either of those would cause the library to fail to build ... |
We're going to need a repro case to help. The example being discussed at google/promises#228 looks like it might be a problem with the TuIst build system. |
@paulb777 Yes we're using Tuist indeed. I didn't think at first it could be related. The repo concerned is a private one. I'll prepare an example project asap and then come back to you. |
@Nonouf & @mojidabckuu what tuist & XCode versions you guys are using? |
@shreyash-sharechat We are using Tuist 3.35.5, Xcode 15.2 and Swift 5.9 |
@shreyash-sharechat |
To reproduce the compilation problem you can easily do this by mkdir firebase-tuist
cd firebase-tuist
echo "3.26.0" >> .tuist-version
tuist bundle
tuist init --platform ios
echo "
import ProjectDescription
let dependencies = Dependencies(
swiftPackageManager: [
.remote(
url: \"https://github.com/firebase/firebase-ios-sdk\",
requirement: .exact(\"10.7.0\")
)
]
)
" >> Tuist/Dependencies.swift Then add .external("FirebaseCrashlytics") to app's target tuist fetch
tuist generate Then build the project |
Here is a sample project using Tuist 3.35.5, Xcode 15.2 and Swift 5.9 : https://github.com/Nonouf/TestTuistFirebase You should just be able to open the workspace and build. |
@paulb777 You are missing dependancies.
or @Nonouf should push whole repo without Also, tuist is not really a build system, it's just project configurator, builds are run by vanilla xcodebuild system only. |
@paulb777 Yes indeed. As @shreyash-sharechat said, it's just the dependencies that are missing. I forgot the gitignore. It'll be up to date shortly. The more I look at the problem, the more it looks like a Tuist issue indeed. I'll forward the issue to the Tuist team if needed. There has been a lot of big changes there very recently with a new major version. |
Though it should all be backwords compatible, because we never updated tuist here. Still running 3.17.0 from couple of years back. |
Folks having issue with Tuist should try upgrade to Tuist 4 according to this: tuist/tuist#6036 (comment) |
Description
Google/Promises has been updated to 2.4.0 a few days ago and it contains a breaking changes.
The firebase iOS SDK is dependant on Promises versions 2.1.0 to 2.9.9. I've opened an issue with the Promises team here, but in the meantime is there anyway to force the firebase SDK to use an older version of Promises?
Reproducing the issue
Firebase SDK Version
10.6.0 (and also tried on the latest 10.21.0)
Xcode Version
15.2
Installation Method
Swift Package Manager
Firebase Product(s)
All
Targeted Platforms
iOS
Relevant Log Output
No response
If using Swift Package Manager, the project's Package.resolved
No response
If using CocoaPods, the project's Podfile.lock
No response
The text was updated successfully, but these errors were encountered: