Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase/Performance crashes Password Autofill screen #2283

Closed
Igor-Palaguta opened this issue Jan 18, 2019 · 21 comments
Closed

Firebase/Performance crashes Password Autofill screen #2283

Igor-Palaguta opened this issue Jan 18, 2019 · 21 comments
Assignees
Milestone

Comments

@Igor-Palaguta
Copy link

@Igor-Palaguta Igor-Palaguta commented Jan 18, 2019

  • Xcode version: 10.0
  • Firebase SDK version: 5.15.0
  • Firebase Component: Performance
  • Component version: 5.15.0

We have very frequent crash 0.5 % of all users who visited registration screen with password autofill fields. We started to have it after adding Firebase/Performance. Also we have confirmation from other developers that after removing Firebase/Performance it stopped crashing. Here is related discussion https://stackoverflow.com/a/54227163/2035054

@ryanwilson
Copy link
Member

@ryanwilson ryanwilson commented Jan 18, 2019

Thanks for the report, also tracked internally at b/123065386.

@visumickey can you investigate and see if Perf is the cause or not? It doesn't look like there are Firebase references in the stack trace, but a few users seem to think Perf is the issue.

Loading

@visumickey
Copy link
Contributor

@visumickey visumickey commented Jan 18, 2019

@Igor-Palaguta Can you share the detailed stack trace for this issue? Firebase performance does not have anything related to the UIActivity on the screen, so it is surprising to hear that the issue is related to UIActions. If this is predictably reproduce-able, can you share any sample app?

It would be helpful to understand the version of the Firebase Performance POD you are using. (Note: Firebase Performance will have its own version number in the Podfile.lock).

Loading

@Igor-Palaguta
Copy link
Author

@Igor-Palaguta Igor-Palaguta commented Jan 18, 2019

@visumickey

Cartfile.resolved

binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseABTestingBinary.json" "5.15.0"
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseAnalyticsBinary.json" "5.15.0"
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebasePerformanceBinary.json" "5.15.0"
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseRemoteConfigBinary.json" "5.15.0"

I could not replicate this issue, just can see crashes in fabric, but some people could do it: https://stackoverflow.com/questions/52879044/crash-in-uikitcore-uiviewcontroller-viewdidmovetowindowshouldappearordisappear#comment93141683_52879044

Yesterday in stackoverflow appeared answer that after removing Firebase/Performance issue gone.
I checked when we added Firebase/Performance (october 2018) and we have this crash exactly after integration. We did not change anything on screen where we have crash for a long time. I also asked one more developer who also have this issue, and he also confirmed that they use Firebase/Performance

Loading

@Batvos
Copy link

@Batvos Batvos commented Jan 19, 2019

@visumickey

Hi,

Here is my test project https://github.com/Batvos/firebaseperfomanceissue where you can reproduce this crash.

Loading

@Igor-Palaguta
Copy link
Author

@Igor-Palaguta Igor-Palaguta commented Jan 21, 2019

@Batvos test app looks empty

Loading

@Batvos
Copy link

@Batvos Batvos commented Jan 21, 2019

@Batvos test app looks empty

Ops, Sorry. I don't know how it happened:) I'll push a normal version today later

Loading

@Batvos
Copy link

@Batvos Batvos commented Jan 21, 2019

@Igor-Palaguta I've updated project. But you need to download your own GoogleService-Info.plist file from firebase project and add it to the root of project. Also you need to install pods.

Loading

@visumickey
Copy link
Contributor

@visumickey visumickey commented Jan 25, 2019

This looks like a very tricky issue. We are able to reproduce the issue, but we are trying ways to find the root cause to have a fix on this. Will keep investigating this crash to arrive at a solution soon.

Loading

@glennposadas
Copy link

@glennposadas glennposadas commented Feb 1, 2019

Any update?

Loading

@Igor-Palaguta
Copy link
Author

@Igor-Palaguta Igor-Palaguta commented Feb 5, 2019

Can confirm that after removing Firebase/Performance library we don't see this crash any more

Loading

@donnellyk
Copy link

@donnellyk donnellyk commented Feb 5, 2019

Also seeing this crash when we added Firebase/Performance

Loading

@AnilVarghese
Copy link

@AnilVarghese AnilVarghese commented Feb 9, 2019

Indeed Firebase/Performance framework is causing the crash.
We are not supporting password autofill in our app, still it crashes. Looks like iOS is internally checking for availabilty of password autofill for textfiled with secure text entry. We have disabled the firebase performance by setting firebase_performance_collection_deactivated to true in Info.plist as a temporary solution.

To reproduce the crash, on sign up screen when the password textfield(secure text entry) is active put the app into background.

Loading

@xuaninbox
Copy link

@xuaninbox xuaninbox commented Feb 13, 2019

Any update on this issue?

Loading

@simonbengtsson
Copy link

@simonbengtsson simonbengtsson commented Feb 17, 2019

We use firebase performance and have this crash as well. I can't see anything about firebase performance in the crash logs however. I have been able to reproduce it, but not consistently. The crashes seems a bit random to me right now.

In our logs we often see that the users who experience this crash often goes to background. But I have been able to reproduce at times without it as well.

Here is a typical crashlog if someone finds it useful: crashlog.txt

UPDATE: Our next release will be without firebase performance, will get back here with results about if we still get the crash logs then.

UPDATE 2: Our next release is out without firebase performance and this crash is not appearing 🎉

Loading

@visumickey
Copy link
Contributor

@visumickey visumickey commented Feb 28, 2019

@Igor-Palaguta Need one more information to debug this further. Do we know the version of Firebase from where this issue has started spiking?

Loading

@Igor-Palaguta
Copy link
Author

@Igor-Palaguta Igor-Palaguta commented Mar 1, 2019

@visumickey we started to use Firebase Performance since October 2018. And it was 5.10.0 version.

Loading

@bettola
Copy link

@bettola bettola commented Mar 1, 2019

We have the same crash on production app

Loading

@choiks14
Copy link

@choiks14 choiks14 commented Mar 6, 2019

same here

Loading

@visumickey
Copy link
Contributor

@visumickey visumickey commented Mar 6, 2019

We have nailed down the issue here and we working on a fix for this. The upcoming release should have the fix rolled out.

Loading

@paulb777 paulb777 added this to the M45 milestone Mar 6, 2019
@flaviobtc
Copy link

@flaviobtc flaviobtc commented Mar 8, 2019

Hey @visumickey, do you have any perspective about when this fix will be released? This is the top crash for my side, unfortunately 😅

Loading

@visumickey
Copy link
Contributor

@visumickey visumickey commented Mar 8, 2019

At this time, we are planning to have this launched at M45. Planned to be available to the developers March 19 (M45).

Loading

@firebase firebase locked and limited conversation to collaborators Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet