-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS 13 Crash - [FIRInstanceIDKeychain itemWithQuery:] #3270
Comments
also firebase remote config crash in iOS13 . |
Same crash for me too. |
I'm looking into this issue. It seems to be caused by a deadlock in RemoteConfig and InstanceID. Will keep this thread updated with details. |
I also have a crash on iOS 13: libdispatch.dylib`DISPATCH_WAIT_FOR_QUEUE: |
@maksymmalyhin reassigning to you since I'm going on vacation next week. I wasn't able to conclusively prove this crash is caused by a deadlock. Here's what I've figured out thus far:
Feel free to assign it back to me when I return from vacation on July 8th. |
I’m also experiencing this problem and I would like to help. What info can I provide? |
@seanpai96 If you see a backtrace different from the one above, please share it. Also, if sharing a reproducible example would be helpful. |
We haven't identified the issue yet, but there's a reasonable chance the bug was introduced in Firebase 6.3.0 in which case the recommended workaround would be adding the following to the Podfile:
|
The debug log logged this first then stucked forever: |
Hi..we are still investigating the root cause. Meanwhile, noticed that you have a remote config fetch call immediately followed by query to get value for a param at startup. Note that Remote Config initializes in an async manner and it is recommended to use ensureInitializedWithCompletionHandler to make sure RC is initialized before fetching and querying for RC values. |
@milo- @seanpai96 can you share the code snippet that causes the crash (did you have Remote Config enabled)? Also, if you are able to repro, would appreciate verbose logs by modifying the loggerLevel https://firebase.google.com/docs/reference/ios/firebasecore/api/reference/Classes/FIRConfiguration |
|
We suspect the crash may be related to FirebasePerformance. Is anyone seeing the crash who does not have FirebasePerformance installed in their app? |
A workaround is to remove FirebasePerformance from the apps that need to run on iOS 13. Stay tuned for info about the fix. |
I was able to get my app to run after removing FirebasePerformance on iOS 13. |
We now have a fix that will be built into the 6.4.0 release that is planned to publish next week. |
Removing Firebase Performance seems to resolve the issue for iOS 13 users. But I still get crashes on startup for some users on iOS 12.3.1, even after removing firebase performance :/ So I'd strongly recommend to downgrade to 6.2.0 |
hello @paulb777 , may I know when the 6.4.0 will be released? |
@romin991 it's already released yesterday |
I have the same issue (deadlock on startup). Will test 6.4.0 to see if the issues goes away |
@mouness2020 that issue doesn't mention iOS 13. Can anyone confirm that 6.4.0 solves the problem? Is there any more info about what caused this issue? And how it was resolved? I got a number of reports from users that the app crashed on startup on iOS13 and iOS 12.3.1. Removing Firebase Performance did not fully resolve the issue. After releasing an app update where I downgraded to 6.2.0 it was resolved. Can we be sure that it won't crash at startup on 6.4.0? |
Downgrading to 6.2.0 doesn't resolve it either. Still having users complaining about crashes. |
Upgrading to 6.4.0 fixed the deadlock issue. |
@sipersso can you please confirm, is the 12.3.1 crash the exact same stack trace you see above? Or is it a separate issue? The crash stems from Performance, so I'm not sure that you're running into the same issue. Any help tracking this down would be greatly appreciated.
The Performance Monitoring changelog does mention the iOS 13 beta crash. Was there another issue you meant?
The issue had to do with a timing issue with the |
@ryanwilson I wish I could provide you with a stacktrace, but I can't. I can't reproduce the issue locally. It is only happening in production Firebase Crashlytics lists the app as 100% crash free and no crash reports, which leads me to believe that the error is during initialization. So far the issue has only been on iOS13 and iOS 12.3.1. Here is what happened. 2: I removed Firebase Performance, but still used 6.3.0. I assume that this is the current issue? 3: I downgraded to 6.2.0: Is this this a separate issue? I have upgrade to 6.4.0 now and I am submitting it to Apple as we speak. I am thinking 12.3.1 and iOS 13 could possibly share the timing issues? |
Thanks for the info. Responses inline...
I'm not sure why Crashlytics wouldn't show these crashes - @samedson any idea why that could be?
This issue reported above is solely due to Firebase Performance. If you removed FirebasePerformance from your application, it must be a separate issue with the app (either the app itself, a different set of frameworks, for Firebase). For what it's worth, we haven't seen other crashers being reported for 6.3.0 on iOS 12.3.1.
Same comment as above, we haven't gotten reports of crashing on iOS 12.3.1 and without a stack trace it's impossible to tell if Firebase is related or not.
Based on you removing Performance and the crashes on 12.3.1 still happening, us not receiving other crashing reports for 12.3.1, and Apple's changes to the startup windowing sequence I believe that the crash you're describing is unrelated to the stacktrace and issue reported above. |
When you have the issue, you get it at 100% of the launches (at least for me) and it's an instant crash, so I doubt crashlytics was able to send the crash report on the next launch (since it would crash too) |
Yep, that's fair 🙂 |
@Valpertui Yes, that is correct. It crashes repeatedly for these users. Not really sure how to open a ticket for this since I can't have any stacktraces, but I have upgraded to 6.4.0 and also noticed that my Firebase initialization was done in willFinishLaunching, and not didFinishLaunching, which I believe would increase the likelyhood it being the timing issue described. So I have moved it. There have been very few reports so far, but so I am leaning towards releasing a phased update containing 6.4.0 and moving the initialization of Firebase to the correct place and see how it goes. A bit scary without the crash reports though. |
I am confident it is related to firebase since the update I started seeing this in only contains a few cosmetic changes and the firebase updates. The other code changes are nowhere near the app startup. |
@ryanwilson @Valpertui that's correct about Crashlytics - it needs to start up successfully before it will start collecting crashes. If an SDK starts before Crashlytics it won't collect a crash from it |
Describe the problem
We released an update yesterday, going from Firebase 6.0.0 to firebase 6.3.0. We've been getting reports of the app crashing on startup for users with iOS 13 beta (17A5508m).
We've not been able to reproduce this ourselves, but we've had at least 5 crashes in the last 12 hours caused by this. Users have reported that uninstalling and reinstalling the app doesn't fix things.
The thread that crashes:
I've attached the full crash log, let me know if I can provide any more info
2019-06-27_02-12-29.9158_+0100-8692347274dbd966774cf859c53577c33a82cbb0.txt
The text was updated successfully, but these errors were encountered: