-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not activate if fetch returns NO_CHANGE #4260
Conversation
@@ -76,6 +76,8 @@ | |||
@property(nonatomic, readwrite, assign) NSTimeInterval lastSetDefaultsTimeInterval; | |||
/// The latest eTag value stored from the last successful response. | |||
@property(nonatomic, readwrite, assign) NSString *lastETag; | |||
/// The timestamp of the last eTag update. | |||
@property(nonatomic, readwrite, assign) NSTimeInterval lastETagUpdateTime; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we persist this value? cuz what happened before the current app launch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good pt. Done.
DISPATCH_QUEUE_SERIAL); | ||
_configFetch[i] = OCMPartialMock([[RCNConfigFetch alloc] initWithContent:configContent | ||
DBManager:_DBManager | ||
settings:settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this format right? Maybe run script/style.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is with style.sh.
Fixes internal bug: 143622863. We activate only if fetched data has not resulted in a data change. We track this using the last time the ETag was changed (corresponds to a real change to the RC template).
This change also mirrors current android behavior.