-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warnings in FIAM test projects #5171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
christibbs
commented
Mar 23, 2020
•
edited
Loading
edited
- Migrate to Swift 5 in UI tests app
- Update to recommended settings in .xcodeproj file for end-to-end integration test app
- Update method signature for application:continueUserActivity: in AppDelegate of end-to-end app
morganchen12
approved these changes
Mar 23, 2020
paulb777
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Two future options to consider:
- Add an option to the Xcode project to fail on warnings
- And/or add option to invocation in build.sh to catch in CI runs
@@ -342,7 +342,7 @@ | |||
isa = PBXProject; | |||
attributes = { | |||
LastSwiftUpdateCheck = 0830; | |||
LastUpgradeCheck = 0900; | |||
LastUpgradeCheck = 1130; | |||
ORGANIZATIONNAME = "Yong Mao"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to Firebase
ryanwilson
pushed a commit
that referenced
this pull request
Apr 24, 2020
* Migrate UI test project to Swift 5 * Fix warning in application:continueUserActivity: method signature * Update to recommended settings in functional test apps * Update to recommended settings in functional tests app * Change organization name to Firebase, treat warnings as error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.