-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a new API that allows iOS users to log notification delivery signal that exports to BigQuery. #6181
Conversation
@chliangGoogle I feel like there must be a LaunchCall associated with the feature. I think it would be useful to link it to the PR somehow. |
I'm still struggling with the nanopb encoding, once the code is ready for review, I will kick off a launchcal. |
@chliangGoogle Is this PR still relevant? If not please close. |
@paulb777 It is blocked on internal PM review. |
Coverage ReportAffected SDKs
Test Logs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a rebase to the latest master and tests passing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a couple minor comments/questions.
…livery signal that exports to BigQuery." (#8458) * Revert "Prevent firelog from logging invalid data (#8443)" This reverts commit 7fc7325. * Revert "Update changelog (#8440)" This reverts commit ecc7d6d. * Revert " Adding a new API that allows iOS users to log notification delivery signal that exports to BigQuery. (#6181)" This reverts commit ce87d25.
We got approved within our team to proceed with this launch. Please review this again, the API review is approved at
go/fm-ios-delivery