Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate missing Analytics warning only for iOS #6500

Merged
merged 1 commit into from Sep 21, 2020
Merged

Conversation

paulb777
Copy link
Member

And simplify warning message so it works for any package manager.

Eliminate the warning since it is not currently possible to solve for macOS, tvOS and watchOS and missing Analytics support is documented.

See #4557 (comment)

For Firebase 7, consider completely eliminating these for iOS as well.

cc: @christibbs @chliangGoogle @eldhosembabu @visumickey @karenyz

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulb777 paulb777 merged commit 0644266 into master Sep 21, 2020
@paulb777 paulb777 deleted the pb-non-ios-warnings branch September 21, 2020 14:18
@firebase firebase locked and limited conversation to collaborators Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants