-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better VoiceOver experience for in-app messages #7445
Conversation
christibbs
commented
Feb 3, 2021
- Announces the in-app message title over VoiceOver at display time
- Improves accessibility labels
- Announces close button as the last accessible VoiceOver element (so it's easier to find)
…ccessibility experience for finding the close button.
…ts. Exclude the image view if there's no image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Is it feasible to add unit tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are test failures on travis with Xcode 11. PTAL
No, fortunately you get some accessibility test coverage for free since the UI testing framework uses accessibility identifiers. But there's no way to test the posting of a VoiceOver notification at a particular time. |