Logging requests are made despite setting FirebaseDataCollectionDefaultEnabled to NO #8220
Labels
Comments
|
Hi @swrobel, thanks for the detailed report and for creating a new issue. I'm personally unfamiliar with the RN side of things but am curious if you could try one thing to see what the local state is like. Can you please do the following:
And then share the logs? I'm also curious to see what the debug logs show for other logs, either |
|
Also, apologies for the trouble: this is not the expected behaviour. We'll try to get to the bottom of it quickly. |
|
@swrobel Thank you for creating a separate issue. I was trying to reproduce this issue with Messaging quickstart project, but with no success:
Based on the above, it doesn't look Firebase SDK is actual a source of the issue by itself. The requests to Would it be possible to share the following:
|
Here you go: https://gist.github.com/swrobel/f5292893142c6cd5f6754edf1a851b7e
I'll work on this one. Thanks for your help! |
|
@swrobel Thank you for sharing the Podfile.lock. From the first glance it looks like |
I added this here. If this isn't the right place, let me know. Apologies for my lack of Xcode knowledge, but such is React Native - giving us js devs sharp knives to run with.
This is erroring out when I build:
|
|
Sorry, there was a typo in the comment. You should update the log to something like: I updated the original comment as well in case if someone else will try it. |
|
Apologies, there was another typo in the comment. The place you are setting the launch argument is correct, but the argument should be |
|
Relevant XCode logs (a few have had tokens/other potentially sensitive stuff removed): Relevant Console logs: |
|
Thank you for sharing the logs. I can see a couple issue here:
Could you please check the first issue on your end. Disabling the data collection should make the other two irrelevant for your case. |
There's just the one Info.plist, shared across all targets. I have other values in it that seem to be read just fine. I can't think of anything that would be stripping it - anything specific to look for?
That's my pihole, doing what it's supposed to do 😄 |
|
Thanks @swrobel. We'll continue investigating. In the meantime, are you able to debug what happens if you set a breakpoint at https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseCore/Sources/FIRApp.m#L820 |
|
OK, this is interesting... It seems from debugging that since the Plist value is a string and Line 822 is checking whether it's a number, then line 823 is never hit. |
|
Defining the value in the Info.plist as a Boolean works for me:
|
|
@paulb777 thanks! It turns out I had the wrong plist format when I was setting it to a string value of NO. This works correctly: <key>FirebaseDataCollectionDefaultEnabled</key>
<false/>It's also reflected in the logs that the value sets correctly (as opposed to However, despite the correct value, the network requests to |
|
@swrobel It's great that this part of issue was resolved for you! If you had data collection enabled the app may have stored some telemetry events. GoogleDataTransport will attempt to upload them until they are sent successfully or expire in around 7 days. If you re-install the app with disabled data collection, the events will not be logged, so no network requests are expected. Could you please try re-installing the app or moving the device time forward to confirm it's working as expected for you? |
|
This does indeed seem to have resolved the issue. I will say that I find it odd that the default behavior is to log, but I'm at least glad it can be disabled with certainty. I'm not sure why it took a few more debug builds in Xcode to get the requests to stop, but they have indeed stopped so I'm satisfied to close this one. I really appreciate all of the help from everyone here! 🙌🏼 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Step 0: Are you in the right place?
file a Github issue.
with the
firebasetag.google group.
of the above categories, reach out to
Firebase Support.
this repository, please delete this section.
[REQUIRED] Step 1: Describe your environment
* @react-native-firebase/messaging: 12.0.0
* @react-native-firebase/app: 12.0.0
* Firebase/CoreOnly (8.0.0)
* Firebase/Messaging (8.0.0)
* FirebaseCore (8.0.0)
* FirebaseCoreDiagnostics (8.1.0)
* FirebaseInstallations (8.1.0)
* FirebaseMessaging (8.0.0)
I previously reported on this issue that turned out to be unrelated and opened a new issue as recommended
Network logs from Flipper:
[REQUIRED] Step 2: Describe the problem
Steps to reproduce:
Relevant Code:
AppDelegate.m
Info.plist
Network request behavior is unchanged after adding this key to Info.plist. I have tried adding the same key to GoogleService-Info-Debug.plist and the behavior is also unchanged.
Solution:
It turns out the correct plist key is:
The text was updated successfully, but these errors were encountered: