Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recaptcha related errors #10048

Merged
merged 4 commits into from
Aug 1, 2022
Merged

Add recaptcha related errors #10048

merged 4 commits into from
Aug 1, 2022

Conversation

renkelvin
Copy link
Contributor

@renkelvin renkelvin commented Jul 27, 2022 •
edited

This PR updates the 4 email auth apis (sign in, sign up, password reset, email link sign in) to support recaptcha enterprise. go/gcip-recaptcha-client-sdk-api

Development progress

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@renkelvin renkelvin requested a review from paulb777 July 28, 2022 00:14
@renkelvin renkelvin marked this pull request as ready for review July 28, 2022 00:14
paulb777
paulb777 approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to see a better error handling architecture, but that's out of scope for this project.

@renkelvin
Copy link
Contributor Author

I'd love to see a better error handling architecture, but that's out of scope for this project.

Yeah, agreed.

@renkelvin renkelvin merged commit c35e4d8 into recaptcha Aug 1, 2022
@renkelvin renkelvin deleted the errors branch August 1, 2022 16:21
@renkelvin renkelvin mentioned this pull request Aug 3, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@rosalyntan rosalyntan Awaiting requested review from rosalyntan

Assignees
No one assigned
Labels
api: auth public-api-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@renkelvin @google-oss-bot @paulb777