Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[auth-swift] AuthTests.swift - 15 more unit tests #11357

Merged
merged 3 commits into from
May 30, 2023
Merged

[auth-swift] AuthTests.swift - 15 more unit tests #11357

merged 3 commits into from
May 30, 2023

Conversation

paulb777
Copy link
Member

  • 15 more AuthTests.swift (25 to go)
  • Refactoring to centralize more common constants in RPCBaseTests
  • Distinguish between User Doe and Google Doe constants to clean up test sloppiness.
  • Fix bug of not propagating fullName from an OAuthCredential to a VerifyAssertionRequest
  • A few additional typo fixes

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@paulb777 paulb777 merged commit 55d7782 into auth-swift May 30, 2023
18 checks passed
@paulb777 paulb777 deleted the pb-finish-authtests branch May 30, 2023 17:59
@firebase firebase locked and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulb777 @google-oss-bot