Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auth-swift] Revoke Token unit tests #11391

Merged
merged 2 commits into from
Jun 9, 2023
Merged

[auth-swift] Revoke Token unit tests #11391

merged 2 commits into from
Jun 9, 2023

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Jun 3, 2023

Add Swift implementations for the two Revoke Token unit tests. This completes the implementation transformation of FIRAuthTests.m to AuthTests.swift

Two Revoke Token implementation questions came up while doing the tests.

  • The old Revoke Token proceeds and the old tests depend on continuing with a nil idToken. I matched this in the Swift implementation
  • The Objective C implementation was using the public getIDToken instead of internalGetToken. This added the requirement to use the main thread internally and made the test implementation difficult. I changed the implementation to use internalGetToken and only do the revokeToken callback on the main thread.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

Copy link
Contributor

@renkelvin renkelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 1 comment.

@paulb777 paulb777 merged commit 9232b71 into auth-swift Jun 9, 2023
18 checks passed
@paulb777 paulb777 deleted the pb-revoke-token branch June 9, 2023 21:55
@firebase firebase locked and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants