-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rollouts]Add remote config logic to featureRollouts test app #12349
Conversation
(cherry picked from commit 896ab15b82c658752f9d89eb6b79a46fa7fb965f)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! 🚀
} | ||
// Uncomment this if test realtime rc | ||
// .onAppear { | ||
// rc.addOnConfigUpdateListener{u, e in rc.activate()}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw, I've found it helpful to create a "toggle" button to turn realtime on and off for testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's really a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add RC fetch and activate logic into test App
-Within RC only schema
-Within RC+Crashlytics schema
Text value is "unfetched" while first launch and change after fetch + activate with targeted value.
![unnamed](https://private-user-images.githubusercontent.com/146472823/301981603-be453cc2-4e4d-456a-be35-e312fdba0839.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE4MjI3MzIsIm5iZiI6MTcyMTgyMjQzMiwicGF0aCI6Ii8xNDY0NzI4MjMvMzAxOTgxNjAzLWJlNDUzY2MyLTRlNGQtNDU2YS1iZTM1LWUzMTJmZGJhMDgzOS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzI0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyNFQxMjAwMzJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05MmZiMjI2MmFiODcxZTc0MTk0N2E2YzAyNTc5ZDNkOGQ5OTYxOWU1Y2YyZWQ1MmRkMjQ4OWIxNzZmZDA5ODgxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.CnOhCscJr8h3sn3MszuHUm1JY6O847PLyDHxpLrp6pw)
Note: this change will merge to our feature branch not master
#no-changelog