Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rollouts]Add remote config logic to featureRollouts test app #12349

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

ddnan
Copy link
Contributor

@ddnan ddnan commented Feb 2, 2024

Add RC fetch and activate logic into test App
-Within RC only schema
-Within RC+Crashlytics schema

Text value is "unfetched" while first launch and change after fetch + activate with targeted value.
unnamed

Note: this change will merge to our feature branch not master
#no-changelog

(cherry picked from commit 896ab15b82c658752f9d89eb6b79a46fa7fb965f)
Copy link
Contributor

@themiswang themiswang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this!

Copy link
Contributor

@karenyz karenyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 🚀

}
// Uncomment this if test realtime rc
// .onAppear {
// rc.addOnConfigUpdateListener{u, e in rc.activate()};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, I've found it helpful to create a "toggle" button to turn realtime on and off for testing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's really a good idea.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a toggle when selected will enable realtime RC (Disable by default)
Screenshot 2024-02-05 at 3 51 38 PM

@ddnan ddnan marked this pull request as ready for review February 6, 2024 01:34
@ddnan ddnan merged commit 90ed828 into featureRollouts Feb 6, 2024
67 of 68 checks passed
@ddnan ddnan deleted the ddn-testApp branch February 6, 2024 03:03
@firebase firebase locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants