Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cmake build to grpc 162 #12417

Merged
merged 20 commits into from
Mar 21, 2024
Merged

Upgrade cmake build to grpc 162 #12417

merged 20 commits into from
Mar 21, 2024

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Feb 22, 2024

Note: we need to change the cocopods files for the test projects because newer version of grpc generate the pb.cc files that require updating the cocoapods configurations. It only impact how we run our tests through xcodebuild, and the actual SDK is not impacted.

There are other various small changes needed to make everything build, i have left comments to call them out. The majority of the changes are coming from generated pb.cc files as a result of protobufcpp upgrade.

@google-oss-bot
Copy link

google-oss-bot commented Feb 22, 2024

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.18% (939a521) to 88.14% (1582fb9) by -0.04%.

    FilenameBase (939a521)Merge (1582fb9)Diff
    exception.cc84.21%23.68%-60.53%
    leveldb_key.cc98.53%99.02%+0.49%
    serializer.cc91.00%91.31%+0.31%
    watch_stream.cc90.70%95.35%+4.65%
    write_stream.cc91.55%94.37%+2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Wvps58GWbS.html

@wu-hui wu-hui changed the base branch from main to wuandy/Grpc161Pods February 26, 2024 19:18
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

[needless to say] I didn't review any file that has

// Generated by the protocol buffer compiler. DO NOT EDIT!

at the top, and assumed the changes were auto-generated.

Firestore/Example/ProtobufCpp.podspec Show resolved Hide resolved
Firestore/Example/ProtobufCpp.podspec Outdated Show resolved Hide resolved
@ehsannas ehsannas assigned wu-hui and unassigned ehsannas Feb 29, 2024
CMakeLists.txt Show resolved Hide resolved
Firestore/Example/Podfile Show resolved Hide resolved
Firestore/Example/ProtobufCpp.podspec Show resolved Hide resolved
@paulb777 paulb777 added this to the 10.23.0 - M145 milestone Mar 11, 2024
@paulb777
Copy link
Member

Should be good to merge now since we're on track to land SPM support for M145.

@paulb777
Copy link
Member

I meant the comment above for #12398

@paulb777 paulb777 removed this from the 10.23.0 - M145 milestone Mar 11, 2024
Base automatically changed from wuandy/Grpc161Pods to main March 11, 2024 17:12
@wu-hui wu-hui merged commit ab606e0 into main Mar 21, 2024
48 of 50 checks passed
@wu-hui wu-hui deleted the wuandy/GRPC162Cmake branch March 21, 2024 17:29
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Apr 9, 2024
….24.0" (#1007)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[firebase/firebase-ios-sdk](https://togithub.com/firebase/firebase-ios-sdk)
| minor | `from: "10.23.1"` -> `from: "10.24.0"` |

---

### Release Notes

<details>
<summary>firebase/firebase-ios-sdk (firebase/firebase-ios-sdk)</summary>

###
[`v10.24.0`](https://togithub.com/firebase/firebase-ios-sdk/releases/tag/10.24.0):
Firebase Apple 10.24.0

[Compare
Source](https://togithub.com/firebase/firebase-ios-sdk/compare/10.23.1...10.24.0)

The Firebase Apple SDK (10.24.0) is now available. For more details, see
the [Firebase Apple SDK release
notes.](https://firebase.google.com/support/release-notes/ios#10.24.0)

To install this SDK, see [Add Firebase to your
project.](https://firebase.google.com/docs/ios/setup)

#### What's Changed

- Remove calls to fstat in crashlytics by
[@&#8203;volantwish](https://togithub.com/volantwish) in
[firebase/firebase-ios-sdk#12531
- fix unit tests by
[@&#8203;themiswang](https://togithub.com/themiswang) in
[firebase/firebase-ios-sdk#12553
- \[Release] Add release note for signed artifact changes by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[firebase/firebase-ios-sdk#12558
- Fix typo by [@&#8203;paulb777](https://togithub.com/paulb777) in
[firebase/firebase-ios-sdk#12565
- \[Firestore] Add a check to ensure FirestoreInternal has same public
headers as Firestore by [@&#8203;ncooke3](https://togithub.com/ncooke3)
in
[firebase/firebase-ios-sdk#12575
- Carthage 10.23.0 by [@&#8203;paulb777](https://togithub.com/paulb777)
in
[firebase/firebase-ios-sdk#12588
- Initial CI for visionOS by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[firebase/firebase-ios-sdk#12578
- Upgrade cmake build to grpc 162 by
[@&#8203;wu-hui](https://togithub.com/wu-hui) in
[firebase/firebase-ios-sdk#12417
- More visionOS CI by [@&#8203;paulb777](https://togithub.com/paulb777)
in
[firebase/firebase-ios-sdk#12608
- Update versions for Release 10.24.0 by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[firebase/firebase-ios-sdk#12594
- \[Release Tooling] Update XCFramework structure by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[firebase/firebase-ios-sdk#12595
- \[Docs] Update `FirebaseCore/CHANGELOG.md` with correct issue # by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[firebase/firebase-ios-sdk#12639
- Adds putFileHandle and putFileHandleAsync by
[@&#8203;mattcomi](https://togithub.com/mattcomi) in
[firebase/firebase-ios-sdk#12580
- \[CocoaPods] Lock FirestoreInternal version to Firestore by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[firebase/firebase-ios-sdk#12654
- Merge 10.23.1 by [@&#8203;paulb777](https://togithub.com/paulb777) in
[firebase/firebase-ios-sdk#12655
- \[Crashlytics] Fix missing Swift header error by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[firebase/firebase-ios-sdk#12659
- Move MIEQ to composite index tests by
[@&#8203;milaGGL](https://togithub.com/milaGGL) in
[firebase/firebase-ios-sdk#12416
- feat: add basic support to build frameworks and zip them for the Apple
Watch by [@&#8203;jasesuperhero](https://togithub.com/jasesuperhero) in
[firebase/firebase-ios-sdk#12624
- Release note for watchOS zip/Carthage by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[firebase/firebase-ios-sdk#12670
- \[Crashlytics] Remove mach_absolute_time usages by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[firebase/firebase-ios-sdk#12664
- Update to SwiftFormat 0.53.5 by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[firebase/firebase-ios-sdk#12665
- Fix typo: Timout -> Timeout by
[@&#8203;Jager-yoo](https://togithub.com/Jager-yoo) in
[firebase/firebase-ios-sdk#12672
- \[Crashlytics] Regenerate privacy manifest by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[firebase/firebase-ios-sdk#12675
- \[Release] Version changelog entries for 10.24.0 by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[firebase/firebase-ios-sdk#12677
- \[Release Tooling] Fix METADATA.md regression introduced in
[#&#8203;12595](https://togithub.com/firebase/firebase-ios-sdk/issues/12595)
by [@&#8203;ncooke3](https://togithub.com/ncooke3) in
[firebase/firebase-ios-sdk#12661
- Analytics 10.24.0 by
[@&#8203;tsunghung](https://togithub.com/tsunghung) in
[firebase/firebase-ios-sdk#12693
- \[Release] Update binary SPM Firestore distro for 10.24.0 by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[firebase/firebase-ios-sdk#12708
- \[Release] Update Firestore's binary deps in Package.swift by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[firebase/firebase-ios-sdk#12709

#### New Contributors

- [@&#8203;volantwish](https://togithub.com/volantwish) made their first
contribution in
[firebase/firebase-ios-sdk#12531
- [@&#8203;mattcomi](https://togithub.com/mattcomi) made their first
contribution in
[firebase/firebase-ios-sdk#12580
- [@&#8203;jasesuperhero](https://togithub.com/jasesuperhero) made their
first contribution in
[firebase/firebase-ios-sdk#12624
- [@&#8203;Jager-yoo](https://togithub.com/Jager-yoo) made their first
contribution in
[firebase/firebase-ios-sdk#12672

**Full Changelog**:
firebase/firebase-ios-sdk@10.23.1...10.24.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
@firebase firebase locked and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants