Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch abseil-cpp to ignore deprecated errors in new Xcode. #12498

Merged
merged 6 commits into from
Mar 8, 2024

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Mar 8, 2024

The current version of abseil-cpp (used by grpc) uses some deprecated builtins, which cause warnings that make the build fail on Xcode 15 (due to warnings-as-errors).

Until grpc is updated, this PR will work around the issue by adding a patch to abseil-cpp to turn off that warning for that file.

@google-oss-bot
Copy link

google-oss-bot commented Mar 8, 2024

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.20% (48a77e3) to 88.08% (d85edf8) by -0.11%.

    FilenameBase (48a77e3)Merge (d85edf8)Diff
    exception.cc84.21%23.68%-60.53%
    leveldb_key.cc98.14%98.82%+0.69%
    leveldb_persistence.cc93.59%92.31%-1.28%
    lru_garbage_collector.cc96.06%91.34%-4.72%
    ordered_code.cc94.39%93.90%-0.49%
    status.cc75.89%73.05%-2.84%
    write_stream.cc91.55%94.37%+2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Azhbxoa1rk.html

@jonsimantov jonsimantov marked this pull request as ready for review March 8, 2024 20:27
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one minor change requested.

cmake/external/abseil-cpp.patch.txt Outdated Show resolved Hide resolved
@jonsimantov jonsimantov merged commit 6ae867d into main Mar 8, 2024
36 of 38 checks passed
@jonsimantov jonsimantov deleted the js-patch-absl branch March 8, 2024 21:30
@jonsimantov jonsimantov restored the js-patch-absl branch March 8, 2024 21:31
@Vyazovoy
Copy link

Hi, @jonsimantov! Doesn't #12538 means that your changes should be reverted?

@firebase firebase locked and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants