Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use declspec in Firestore on Windows machines #12758

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Use declspec in Firestore on Windows machines #12758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions Firestore/core/src/util/string_format.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ static const char* kInvalid = "<invalid>";

// Disable asan for this function because of the way it manages stack
// (nested closure) is flaged with stack underflow by clang on Ubuntu.
#if defined(_MSC_VER)
__declspec(no_sanitize_address) std::string StringFormatPieces(
#else
__attribute__((no_sanitize_address)) std::string StringFormatPieces(
#endif
const char* format, std::initializer_list<absl::string_view> pieces) {
std::string result;

Expand Down