Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure NSUserDefaults is synchronized after setting values #1646

Merged
merged 1 commit into from Aug 13, 2018

Conversation

@chliangGoogle
Copy link
Contributor

@chliangGoogle chliangGoogle commented Aug 7, 2018

This ensure the aync persist is complete before continue. This should fix the flakiness of integration tests.

@chliangGoogle chliangGoogle changed the title ensure user defaults is synchronized after setting values ensure NSUserDefaults is synchronized after setting values Aug 7, 2018
Copy link
Contributor

@morganchen12 morganchen12 left a comment

This change is harmless, but I'm not convinced it'll resolve the flakiness. Normally calling synchronize after writing a value is unnecessary (see the "Storing user settings in NSUserDefaults" section here).

Loading

@chliangGoogle chliangGoogle merged commit 5fa898e into master Aug 13, 2018
2 checks passed
Loading
@morganchen12 morganchen12 deleted the fcm-userdefaults branch Aug 13, 2018
@firebase firebase locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants