Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Source FirebaseDynamicLinks #1842

Merged
merged 7 commits into from Sep 19, 2018
Merged

Open Source FirebaseDynamicLinks #1842

merged 7 commits into from Sep 19, 2018

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Sep 19, 2018

Open source DynamicLinks
Add FirebaseAnalyticsInterop
style
Add temporary FirebaseAnalytics podspecs until Firebase 5.9.0 is published.

I'll wait for travis green to push, but reviews accepted earlier.

Once this PR lands, I plan to publish FirebaseAnalyticsInterop to enable 'pod lib lint' testing for FirebaseDynamicLinks.

Copy link
Contributor

@dmandar dmandar left a comment

Thanks for your help!

Copy link
Member

@ryanwilson ryanwilson left a comment

Just a few small things on my end, otherwise LGTM! Thanks so much for the hard work on this.

Example/DynamicLinks/App/iOS/FIRAppDelegate.h Show resolved Hide resolved
FirebaseAnalyticsInterop.podspec Outdated Show resolved Hide resolved
GoogleAppMeasurement.podspec.json Show resolved Hide resolved
@paulb777 paulb777 merged commit c724f9d into master Sep 19, 2018
2 checks passed
@paulb777 paulb777 added this to the 5.9.0 milestone Sep 20, 2018
@paulb777 paulb777 deleted the pb-dl-os branch Mar 20, 2019
@firebase firebase locked and limited conversation to collaborators Oct 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants