Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set a timeout on Functions. #2329

Merged
merged 4 commits into from Feb 25, 2019
Merged

Conversation

@bklimt
Copy link
Contributor

@bklimt bklimt commented Jan 31, 2019

Add a timeoutInterval property to FIRHTTPSCallable.h.

@bklimt bklimt requested a review from paulb777 Jan 31, 2019
Copy link
Member

@paulb777 paulb777 left a comment

LGTM, passing to @ryanwilson for API review

@paulb777 paulb777 requested a review from ryanwilson Jan 31, 2019
Copy link
Member

@paulb777 paulb777 left a comment

Fix style and any other travis issues

@ryanwilson
Copy link
Member

@ryanwilson ryanwilson commented Feb 12, 2019

@bklimt did you want to land this for M43?

@bklimt
Copy link
Contributor Author

@bklimt bklimt commented Feb 12, 2019

@ryanwilson Thank you for checking, but no, I'd like to hold this for M44 so I can get the iOS, Android, and Web versions in at the same release.

@bklimt
Copy link
Contributor Author

@bklimt bklimt commented Feb 19, 2019

That Travis failure looks like it doesn't have anything to do with my changes.

@ryanwilson
Copy link
Member

@ryanwilson ryanwilson commented Feb 21, 2019

Paul fixed the Travis issue and I restarted the failed jobs - you're good to go now @bklimt.

@ryanwilson ryanwilson added this to the M44 milestone Feb 21, 2019
@bklimt bklimt merged commit 075e586 into master Feb 25, 2019
2 checks passed
@paulb777 paulb777 deleted the klimt.functions-timeout branch Oct 2, 2019
@firebase firebase locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants