Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reflection call to get checkin info from InstanceID #2825

Merged
merged 6 commits into from Apr 16, 2019

Conversation

@chliangGoogle
Copy link
Contributor

@chliangGoogle chliangGoogle commented Apr 12, 2019

Now that we remove the reflection call, the class FIRMessagingCheckinService is empty, so remove the class completely and access checkin info directly using private API for FCM

Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

LGTM

Example/Messaging/Tests/FIRMessagingRegistrarTest.m Outdated Show resolved Hide resolved
Copy link
Member

@paulb777 paulb777 left a comment

Nice cleanup!

InstanceID needs to be tagged and pushed to https://github.com/firebase/SpecsStaging to get the travis tests passing.

@chliangGoogle chliangGoogle requested a review from paulb777 Apr 15, 2019
@chliangGoogle chliangGoogle merged commit 8540c21 into master Apr 16, 2019
2 checks passed
@chliangGoogle chliangGoogle deleted the fcm-clean-reflection branch Apr 16, 2019
@firebase firebase locked and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants