Adding macOS support for Messaging and InstanceID

[charlotteliang]

With this change, developers can use FCM to send push notifications on macOS app.

[wilhuff]

Please resolve style issues.

[maksymmalyhin]

@chliangGoogle FYI #2911. The PR is waiting for a review from @tejasd

[paulb777]

Seeing tvOS build errors - firebase-ios-sdk/Firebase/InstanceID/FIRInstanceID.m:1183:8: error: use of undeclared identifier 'apsEnvironment'

[paulb777]

Update .travis.yml to run InstanceID for macos (two places)

Also, if you like, the architecture flags may no longer be necessary after Maksym's stability fixes.

[charlotteliang]

The architecture flags are the updated version, I believe, but I can let Maksym test again to see if some of them can be removed.

Regarding the error: https://travis-ci.org/firebase/firebase-ios-sdk/jobs/538889246#L1757

I have to manually set "Weak References in Manual Retain Release" to true under the FirebaseMessaging-MacOS-Unit-Unit pod, I wonder what I need to do in podspec to reflect such flag automatically so travis can pass green?

[paulb777]

You can set options for the test target's build config here - https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseMessaging.podspec#L56.

Out of curiosity, what's special about macos that it needs that flag?

[charlotteliang]

So that's the weird part: for iOS and tvOS, xcode is default "true", for macOS it's default "false".

[charlotteliang]

There are some breakage but none of them seem related to fcm/iid.

[paulb777]

I see two issues - one might be an iOS flake, but the second seems like real tvOS issues.

In https://travis-ci.org/firebase/firebase-ios-sdk/jobs/538966556:

Failing tests:
-[FIRInstanceIDTokenManagerTest testDeleteTokenSuccess]
** TEST FAILED **

In https://travis-ci.org/firebase/firebase-ios-sdk/jobs/538966560

 - WARN  | xcodebuild:  /Users/travis/build/firebase/firebase-ios-sdk/Firebase/Messaging/FIRMessagingRemoteNotificationsProxy.m:395:1: warning: implementing deprecated method [-Wdeprecated-implementations]
- NOTE  | xcodebuild:  /Applications/Xcode-10.1.app/Contents/Developer/Platforms/AppleTVSimulator.platform/Developer/SDKs/AppleTVSimulator12.1.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIApplication.h:346:1: note: method 'application:didReceiveRemoteNotification:' declared here
- WARN  | [tvOS] xcodebuild:  /Users/travis/build/firebase/firebase-ios-sdk/Example/Messaging/Tests/FIRMessagingRemoteNotificationsProxyTest.m:68:1: warning: implementing deprecated method [-Wdeprecated-implementations]
- WARN  | [tvOS] xcodebuild:  /Users/travis/build/firebase/firebase-ios-sdk/Example/Messaging/Tests/FIRMessagingRemoteNotificationsProxyTest.m:196:26: warning: 'application:didReceiveRemoteNotification:' is deprecated: first deprecated in tvOS 10.0 - Use UserNotifications Framework's -[UNUserNotificationCenterDelegate willPresentNotification:withCompletionHandler:] or -[UNUserNotificationCenterDelegate didReceiveNotificationResponse:withCompletionHandler:] for user visible notifications and -[UIApplicationDelegate application:didReceiveRemoteNotification:fetchCompletionHandler:] for silent remote notifications [-Wdeprecated-declarations]
- NOTE  | xcodebuild:  /Applications/Xcode-10.1.app/Contents/Developer/Platforms/AppleTVSimulator.platform/Developer/SDKs/AppleTVSimulator12.1.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIApplication.h:346:1: note: 'application:didReceiveRemoteNotification:' has been explicitly marked deprecated here
- WARN  | [tvOS] xcodebuild:  /Users/travis/build/firebase/firebase-ios-sdk/Example/Messaging/Tests/FIRMessagingRemoteNotificationsProxyTest.m:230:16: warning: 'application:didReceiveRemoteNotification:' is deprecated: first deprecated in tvOS 10.0 - Use UserNotifications Framework's -[UNUserNotificationCenterDelegate willPresentNotification:withCompletionHandler:] or -[UNUserNotificationCenterDelegate didReceiveNotificationResponse:withCompletionHandler:] for user visible notifications and -[UIApplicationDelegate application:didReceiveRemoteNotification:fetchCompletionHandler:] for silent remote notifications [-Wdeprecated-declarations]

[paulb777]

Nice!

[maksymmalyhin]

👍