kill assertion code #3028
Merged
kill assertion code #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
approved these changes
May 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the _FIRInstanceIDDevAssert which is supposed to be running only for debug mode. And it crashes the app when there's an error occurred. However, we already have error checking at the same time so there's no need to assert anything. Remove all the assertion logic to simplify the code base.
For assertion on condition that is already checked in code, remove the assertion.
For assertion on conditions that is not checked, remove the assertion and add a check and log with error or debug log.
This partially resolves the crash in #3018 but we are still investigating reason causing the error to occur.