Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Segmentation SDK structure for source and unit tests. #3214

Merged
merged 4 commits into from
Jul 16, 2019

Conversation

dmandar
Copy link
Contributor

@dmandar dmandar commented Jun 18, 2019

No description provided.

@morganchen12
Copy link
Contributor

Please wait for Ryan/Paul review before merging.

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to CI. #3115 is a good reference for the necessary changes.

s.public_header_files = 'Segmentation/Sources/Public/*.h'

s.dependency 'FirebaseCore', '~> 6.0'
s.dependency 'FirebaseInstanceID', '~> 4.1.1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should only depend on minor versions. Change to 4.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Segmentation/Sources/FIRSegmentation.m Outdated Show resolved Hide resolved
Segmentation/Tests/Unit/Tests-Info.plist Outdated Show resolved Hide resolved
Segmentation/Tests/Unit/en.lproj/InfoPlist.strings Outdated Show resolved Hide resolved
@paulb777
Copy link
Member

If you like, the CI integration can wait until the PR to merge to master.

To add to CI for md-floc-master add the branch name to the bottom of .travis.yml.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@paulb777
Copy link
Member

The diff is unmanageable now. One solution might be to merge master into md-floc-master.

If you haven't yet, review https://github.com/firebase/firebase-ios-sdk/blob/master/AddNewPod.md

@dmandar dmandar requested a review from paulb777 July 16, 2019 18:29
@dmandar
Copy link
Contributor Author

dmandar commented Jul 16, 2019

The diff is unmanageable now. One solution might be to merge master into md-floc-master.

If you haven't yet, review https://github.com/firebase/firebase-ios-sdk/blob/master/AddNewPod.md

Merged into md-floc-master. Glanced through the doc and made changes.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@dmandar dmandar merged commit d7d3200 into md-floc-master Jul 16, 2019
@dmandar dmandar deleted the md-floc-structure branch July 16, 2019 21:04
@firebase firebase locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants