-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Segmentation SDK structure for source and unit tests. #3214
Conversation
Please wait for Ryan/Paul review before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add to CI. #3115 is a good reference for the necessary changes.
FirebaseSegmentation.podspec
Outdated
s.public_header_files = 'Segmentation/Sources/Public/*.h' | ||
|
||
s.dependency 'FirebaseCore', '~> 6.0' | ||
s.dependency 'FirebaseInstanceID', '~> 4.1.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should only depend on minor versions. Change to 4.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
If you like, the CI integration can wait until the PR to merge to master. To add to CI for |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
The diff is unmanageable now. One solution might be to merge master into md-floc-master. If you haven't yet, review https://github.com/firebase/firebase-ios-sdk/blob/master/AddNewPod.md |
Merged into md-floc-master. Glanced through the doc and made changes. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
…te podspec to include search header path.
No description provided.