-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the FCM Direct Channel API from Messaging #6430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see much code deletion!
Please fix the GHA failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍 amazing, I didn't know there was this much red in the whole galaxy!
@@ -57,41 +57,6 @@ typedef void (^FIRMessagingDeleteFCMTokenCompletion)(NSError *_Nullable error) | |||
typedef void (^FIRMessagingTopicOperationCompletion)(NSError *_Nullable error); | |||
|
|||
#if defined(__IPHONE_10_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_10_0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This conditional can be cleared as well for a nicer cleanup - I think this was obsolete once we started requiring Xcode 8 😝 Just for a follow up PR - no need to do it here
Remove the deprecated FCM direct channel and Upstream Send from Messaging. This includes the API, code and tests.
This also removes protocol buffer dependency.
Fixed #5216.