Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDT tests: Xcode 12 fixes #6469

Merged
merged 2 commits into from
Sep 16, 2020
Merged

GDT tests: Xcode 12 fixes #6469

merged 2 commits into from
Sep 16, 2020

Conversation

maksymmalyhin
Copy link
Contributor

@maksymmalyhin maksymmalyhin commented Sep 15, 2020 •
edited
Loading

  • XCAssert maros family doesn't use self reference in Xcode 12 any more, so using XCAssert... in blocks doesn't require weakSelf. Added __unused modifier to silent the Xcode 12 warnings that fail pod lib lint.

#no-changelog

ryanwilson
ryanwilson approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM as long as it doesn't cause warnings to appear when linting with Xcode 11

@maksymmalyhin maksymmalyhin merged commit cd84490 into master Sep 16, 2020
@maksymmalyhin maksymmalyhin deleted the mm/gdt--tests-xcode12 branch September 16, 2020 14:45
@firebase firebase locked and limited conversation to collaborators Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees
No one assigned
Labels
cla: yes GoogleDataTransport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maksymmalyhin @ryanwilson @googlebot @google-oss-bot