Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDTCORFlatFileStorageTest size limit tests: use timeout proportional to the number of events #6537

Merged
merged 1 commit into from
Sep 23, 2020
Merged

GDTCORFlatFileStorageTest size limit tests: use timeout proportional to the number of events #6537

merged 1 commit into from
Sep 23, 2020

Conversation

maksymmalyhin
Copy link
Contributor

@maksymmalyhin maksymmalyhin commented Sep 23, 2020 •
edited
Loading

This should fix test flakes like this

#no-changelog

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@maksymmalyhin maksymmalyhin marked this pull request as ready for review September 23, 2020 16:58
@maksymmalyhin maksymmalyhin merged commit 8779479 into master Sep 23, 2020
@maksymmalyhin maksymmalyhin deleted the mm/gdt-tests branch September 23, 2020 17:44
christibbs pushed a commit that referenced this pull request Sep 28, 2020
@maksymmalyhin @christibbs
GDTCORFlatFileStorageTest size limit tests: use timeout proportional …
63a5188 
…to the number of events (#6537)
@firebase firebase locked and limited conversation to collaborators Oct 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
cla: yes GoogleDataTransport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maksymmalyhin @google-oss-bot @paulb777 @googlebot